github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Error "slice bounds out of range" with LDAP SSH keys #2868

New Issue
Closed
opened 2025-11-02 04:51:56 -06:00 by GiteaMirror · 5 comments
GiteaMirror commented 2025-11-02 04:51:56 -06:00
Owner
Copy Link

Originally created by @silverwind on GitHub (Feb 6, 2019).

I have a LDAP auth source and a user that has no SSH public keys on LDAP. When I add the attribute 'sshPublicKey' to the authentication source, the user can no longer log in on the web interface and the following panic is logged in gitea.log. If I remove the LDAP attribute, the user is again able to log in. I assume that case of empty sshPublicKey result may not be handled properly around user.go:1504.

PANIC:: runtime error: slice bounds out of range
/usr/lib/golang/src/runtime/panic.go:513 (0x42def8)
        gopanic: reflectcall(nil, unsafe.Pointer(d.fn), deferArgs(d), uint32(d.siz), uint32(d.siz))
/usr/lib/golang/src/runtime/panic.go:54 (0x42ce69)
        panicslice: panic(sliceError)
gitea/models/user.go:1504 (0x100d850)
gitea/models/login_source.go:399 (0xf89dd9)
gitea/models/login_source.go:605 (0xf8afa8)
gitea/models/login_source.go:662 (0xf8b5ec)
gitea/routers/user/auth.go:156 (0x117dd8a)
/usr/lib/golang/src/runtime/asm_amd64.s:523 (0x45c82a)
        call64: CALLFN(·call64, 64)
/usr/lib/golang/src/reflect/value.go:447 (0x4c47a3)
        Value.call: call(frametype, fn, args, uint32(frametype.size), uint32(retOffset))
/usr/lib/golang/src/reflect/value.go:308 (0x4c4233)
        Value.Call: return v.call("Call", in)
gitea/vendor/github.com/go-macaron/inject/inject.go:177 (0x9648b3)
gitea/vendor/github.com/go-macaron/inject/inject.go:137 (0x964219)
gitea/vendor/gopkg.in/macaron.v1/context.go:121 (0x9924a0)
gitea/vendor/gopkg.in/macaron.v1/context.go:112 (0x9923be)
gitea/modules/context/panic.go:40 (0x10b5543)
/usr/lib/golang/src/runtime/asm_amd64.s:522 (0x45c7aa)
        call32: CALLFN(·call32, 32)
/usr/lib/golang/src/reflect/value.go:447 (0x4c47a3)
        Value.call: call(frametype, fn, args, uint32(frametype.size), uint32(retOffset))
/usr/lib/golang/src/reflect/value.go:308 (0x4c4233)
        Value.Call: return v.call("Call", in)
gitea/vendor/github.com/go-macaron/inject/inject.go:177 (0x9648b3)
gitea/vendor/github.com/go-macaron/inject/inject.go:137 (0x964219)
gitea/vendor/gopkg.in/macaron.v1/context.go:121 (0x9924a0)
gitea/vendor/gopkg.in/macaron.v1/context.go:112 (0x9923be)
gitea/vendor/github.com/go-macaron/session/session.go:192 (0x9e681e)
gitea/vendor/gopkg.in/macaron.v1/context.go:79 (0x992340)
gitea/vendor/github.com/go-macaron/inject/inject.go:157 (0x9645a0)
gitea/vendor/github.com/go-macaron/inject/inject.go:135 (0x96430b)
gitea/vendor/gopkg.in/macaron.v1/context.go:121 (0x9924a0)
gitea/vendor/gopkg.in/macaron.v1/context.go:112 (0x9923be)
gitea/vendor/gopkg.in/macaron.v1/recovery.go:161 (0x9a32da)
gitea/vendor/gopkg.in/macaron.v1/logger.go:40 (0x995663)
gitea/vendor/github.com/go-macaron/inject/inject.go:157 (0x9645a0)
gitea/vendor/github.com/go-macaron/inject/inject.go:135 (0x96430b)
gitea/vendor/gopkg.in/macaron.v1/context.go:121 (0x9924a0)
gitea/vendor/gopkg.in/macaron.v1/context.go:112 (0x9923be)
gitea/vendor/gopkg.in/macaron.v1/logger.go:52 (0x9a25f0)
gitea/vendor/gopkg.in/macaron.v1/logger.go:40 (0x995663)
gitea/vendor/github.com/go-macaron/inject/inject.go:157 (0x9645a0)
gitea/vendor/github.com/go-macaron/inject/inject.go:135 (0x96430b)
gitea/vendor/gopkg.in/macaron.v1/context.go:121 (0x9924a0)
gitea/vendor/gopkg.in/macaron.v1/router.go:187 (0x9a44e7)
gitea/vendor/gopkg.in/macaron.v1/router.go:294 (0x99de16)
gitea/vendor/gopkg.in/macaron.v1/macaron.go:220 (0x9969a1)
gitea/vendor/github.com/gorilla/context/context.go:141 (0xe110ea)
/usr/lib/golang/src/net/http/server.go:1964 (0x6c1f33)
        HandlerFunc.ServeHTTP: f(w, r)
/usr/lib/golang/src/net/http/server.go:2741 (0x6c4c3a)
        serverHandler.ServeHTTP: handler.ServeHTTP(rw, req)
/usr/lib/golang/src/net/http/server.go:1847 (0x6c0f95)
        (*conn).serve: serverHandler{c.server}.ServeHTTP(w, w.req)
/usr/lib/golang/src/runtime/asm_amd64.s:1333 (0x45e4c0)
        goexit: BYTE    $0x90   // NOP
Originally created by @silverwind on GitHub (Feb 6, 2019). - Gitea version (or commit ref): https://github.com/go-gitea/gitea/commit/0c721fe016919e368e105142d45efcd4d477757b I have a LDAP auth source and a user that has no SSH public keys on LDAP. When I add the attribute 'sshPublicKey' to the authentication source, the user can no longer log in on the web interface and the following panic is logged in `gitea.log`. If I remove the LDAP attribute, the user is again able to log in. I assume that case of empty `sshPublicKey` result may not be handled properly around [`user.go:1504`](https://github.com/go-gitea/gitea/blob/0c721fe016919e368e105142d45efcd4d477757b/models/user.go#L1504). ```` PANIC:: runtime error: slice bounds out of range /usr/lib/golang/src/runtime/panic.go:513 (0x42def8) gopanic: reflectcall(nil, unsafe.Pointer(d.fn), deferArgs(d), uint32(d.siz), uint32(d.siz)) /usr/lib/golang/src/runtime/panic.go:54 (0x42ce69) panicslice: panic(sliceError) gitea/models/user.go:1504 (0x100d850) gitea/models/login_source.go:399 (0xf89dd9) gitea/models/login_source.go:605 (0xf8afa8) gitea/models/login_source.go:662 (0xf8b5ec) gitea/routers/user/auth.go:156 (0x117dd8a) /usr/lib/golang/src/runtime/asm_amd64.s:523 (0x45c82a) call64: CALLFN(·call64, 64) /usr/lib/golang/src/reflect/value.go:447 (0x4c47a3) Value.call: call(frametype, fn, args, uint32(frametype.size), uint32(retOffset)) /usr/lib/golang/src/reflect/value.go:308 (0x4c4233) Value.Call: return v.call("Call", in) gitea/vendor/github.com/go-macaron/inject/inject.go:177 (0x9648b3) gitea/vendor/github.com/go-macaron/inject/inject.go:137 (0x964219) gitea/vendor/gopkg.in/macaron.v1/context.go:121 (0x9924a0) gitea/vendor/gopkg.in/macaron.v1/context.go:112 (0x9923be) gitea/modules/context/panic.go:40 (0x10b5543) /usr/lib/golang/src/runtime/asm_amd64.s:522 (0x45c7aa) call32: CALLFN(·call32, 32) /usr/lib/golang/src/reflect/value.go:447 (0x4c47a3) Value.call: call(frametype, fn, args, uint32(frametype.size), uint32(retOffset)) /usr/lib/golang/src/reflect/value.go:308 (0x4c4233) Value.Call: return v.call("Call", in) gitea/vendor/github.com/go-macaron/inject/inject.go:177 (0x9648b3) gitea/vendor/github.com/go-macaron/inject/inject.go:137 (0x964219) gitea/vendor/gopkg.in/macaron.v1/context.go:121 (0x9924a0) gitea/vendor/gopkg.in/macaron.v1/context.go:112 (0x9923be) gitea/vendor/github.com/go-macaron/session/session.go:192 (0x9e681e) gitea/vendor/gopkg.in/macaron.v1/context.go:79 (0x992340) gitea/vendor/github.com/go-macaron/inject/inject.go:157 (0x9645a0) gitea/vendor/github.com/go-macaron/inject/inject.go:135 (0x96430b) gitea/vendor/gopkg.in/macaron.v1/context.go:121 (0x9924a0) gitea/vendor/gopkg.in/macaron.v1/context.go:112 (0x9923be) gitea/vendor/gopkg.in/macaron.v1/recovery.go:161 (0x9a32da) gitea/vendor/gopkg.in/macaron.v1/logger.go:40 (0x995663) gitea/vendor/github.com/go-macaron/inject/inject.go:157 (0x9645a0) gitea/vendor/github.com/go-macaron/inject/inject.go:135 (0x96430b) gitea/vendor/gopkg.in/macaron.v1/context.go:121 (0x9924a0) gitea/vendor/gopkg.in/macaron.v1/context.go:112 (0x9923be) gitea/vendor/gopkg.in/macaron.v1/logger.go:52 (0x9a25f0) gitea/vendor/gopkg.in/macaron.v1/logger.go:40 (0x995663) gitea/vendor/github.com/go-macaron/inject/inject.go:157 (0x9645a0) gitea/vendor/github.com/go-macaron/inject/inject.go:135 (0x96430b) gitea/vendor/gopkg.in/macaron.v1/context.go:121 (0x9924a0) gitea/vendor/gopkg.in/macaron.v1/router.go:187 (0x9a44e7) gitea/vendor/gopkg.in/macaron.v1/router.go:294 (0x99de16) gitea/vendor/gopkg.in/macaron.v1/macaron.go:220 (0x9969a1) gitea/vendor/github.com/gorilla/context/context.go:141 (0xe110ea) /usr/lib/golang/src/net/http/server.go:1964 (0x6c1f33) HandlerFunc.ServeHTTP: f(w, r) /usr/lib/golang/src/net/http/server.go:2741 (0x6c4c3a) serverHandler.ServeHTTP: handler.ServeHTTP(rw, req) /usr/lib/golang/src/net/http/server.go:1847 (0x6c0f95) (*conn).serve: serverHandler{c.server}.ServeHTTP(w, w.req) /usr/lib/golang/src/runtime/asm_amd64.s:1333 (0x45e4c0) goexit: BYTE $0x90 // NOP ````
GiteaMirror added the type/bug label 2025-11-02 04:51:56 -06:00
GiteaMirror commented 2025-11-02 04:51:57 -06:00
Author
Owner
Copy Link

@lafriks commented on GitHub (Feb 6, 2019):

I think it is related to #5928
edit: not related, this is different bug

@lafriks commented on GitHub (Feb 6, 2019): ~~I think it is related to #5928~~ **edit:** not related, this is different bug
GiteaMirror commented 2025-11-02 04:51:57 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (Feb 6, 2019):

Pretty sure the issue is that the LDAP result is "" and strings.Split(v, " ") results in [""] where index 2 is out of bounds.

@silverwind commented on GitHub (Feb 6, 2019): Pretty sure the issue is that the LDAP result is `""` and `strings.Split(v, " ")` results in `[""]` where index 2 is out of bounds.
GiteaMirror commented 2025-11-02 04:51:58 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Feb 6, 2019):

yup that looks like that would be the problem...

@zeripath commented on GitHub (Feb 6, 2019): yup that looks like that would be the problem...
GiteaMirror commented 2025-11-02 04:51:58 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Feb 6, 2019):

OK I've put a PR up. I wasn't sure if you were wanting to do this.

If you can, could you test to see if there's another bug that this is being hidden by this one?

@zeripath commented on GitHub (Feb 6, 2019): OK I've put a PR up. I wasn't sure if you were wanting to do this. If you can, could you test to see if there's another bug that this is being hidden by this one?
GiteaMirror commented 2025-11-02 04:51:58 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (Feb 7, 2019):

No problem, I had the exact same fix in mind, but wanted to test it before sending a PR. Deployed the fix now and the user was able to login, thanks!

@silverwind commented on GitHub (Feb 7, 2019): No problem, I had the exact same fix in mind, but wanted to test it before sending a PR. Deployed the fix now and the user was able to login, thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#2868
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?