github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Deleting a Repo should delete all Commit Statuses #2848

New Issue
Closed
opened 2025-11-02 04:51:01 -06:00 by GiteaMirror · 2 comments
GiteaMirror commented 2025-11-02 04:51:01 -06:00
Owner
Copy Link

Originally created by @jolheiser on GitHub (Feb 1, 2019).

  • Gitea version (or commit ref): current
  • Git version: Any
  • Operating system: All
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

When deleting a repo, currently all commit statuses are being left in the database. Gitea should clean up this table as well when deleting a repo.

Based on the CommitStatus struct having a RepoID here I believe it should be as easy as adding it to the list here

Let me know if this sounds correct and I'd be happy to submit a PR.
I only noticed this when testing the commit status API, there may be more things that can be cleaned up as well.

Originally created by @jolheiser on GitHub (Feb 1, 2019). - Gitea version (or commit ref): current - Git version: Any - Operating system: All - Database (use `[x]`): - [x] PostgreSQL - [x] MySQL - [x] MSSQL - [x] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [x] Not relevant - Log gist: ## Description When deleting a repo, currently all commit statuses are being left in the database. Gitea should clean up this table as well when deleting a repo. Based on the CommitStatus struct having a RepoID [here](https://github.com/go-gitea/gitea/blob/80098bd7526fed84cfb4fa48272be71541b37205/models/status.go#L58) I believe it should be as easy as adding it to the list [here](https://github.com/go-gitea/gitea/blob/80098bd7526fed84cfb4fa48272be71541b37205/models/repo.go#L1775) Let me know if this sounds correct and I'd be happy to submit a PR. I only noticed this when testing the commit status API, there may be more things that can be cleaned up as well.
GiteaMirror added the type/bug label 2025-11-02 04:51:01 -06:00
GiteaMirror commented 2025-11-02 04:51:02 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Feb 2, 2019):

Yes that would do it.

@zeripath commented on GitHub (Feb 2, 2019): Yes that would do it.
GiteaMirror commented 2025-11-02 04:51:02 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Feb 2, 2019):

If you'd like to submit a PR I'd be happy to 👍 it

@zeripath commented on GitHub (Feb 2, 2019): If you'd like to submit a PR I'd be happy to :+1: it
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#2848
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?