Incorrect URL for compare button on non forked repos not owned by user #2846

New Issue

GiteaMirror · 2025-11-02T04:50:52-06:00

GiteaMirror commented

2025-11-02 04:50:52 -06:00

Originally created by @juanpablo-santos on GitHub (Feb 1, 2019).

Gitea version (or commit ref): 1.7.1
Git version: 2.14.3
Operating system: Ubuntu
Database (use [x]):
- PostgreSQL
- [ X] MySQL
- MSSQL
- SQLite
Can you reproduce the bug at https://try.gitea.io:
- [ X] Yes (see below, you need at least a couple of users to reproduce the bug)
- No
- Not relevant
Log gist:

Description

Hi,

we've recently migrated to 1.7.1, and the compare button is showing the .SignedUserName for repositories which are neither a fork nor owned by the user. This wasn't happening on 1.6.0.

Seems 5c30817b5f introduced this behaviour, as part of #5877 released on 1.7.1.

How to reproduce

on try.gitea.io, user perry1234 created repo test-repo123 and added perry1235 as a collaborator, with admin rights

test-repo123 has two branches. When perry1235 clicks on the compare button, he gets an incorrect URL (see attached screenshot)

Screenshots

Originally created by @juanpablo-santos on GitHub (Feb 1, 2019).  - Gitea version (or commit ref): 1.7.1 - Git version: 2.14.3 - Operating system: Ubuntu - Database (use `[x]`): - [ ] PostgreSQL - [ X] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ X] Yes (see below, you need at least a couple of users to reproduce the bug) - [ ] No - [ ] Not relevant - Log gist: ## Description Hi, we've recently migrated to 1.7.1, and the compare button is showing the `.SignedUserName` for repositories which are neither a fork nor owned by the user. This wasn't happening on 1.6.0. Seems https://github.com/go-gitea/gitea/commit/5c30817b5fa1fdeedc8d4fc02cf228dc0e6dc556 introduced this behaviour, as part of #5877 released on 1.7.1. ## How to reproduce on try.gitea.io, user perry1234 created repo [test-repo123](https://try.gitea.io/perry1234/test-perry123) and added perry1235 as a collaborator, with admin rights test-repo123 has two branches. When perry1235 clicks on the compare button, he gets an incorrect URL (see attached screenshot) ## Screenshots ![image](https://user-images.githubusercontent.com/1218530/52123144-16352700-261d-11e9-8f1f-a3519cb71d0a.png)

GiteaMirror added the issue/confirmed topic/ui issue/regression type/bug labels 2025-11-02 04:50:52 -06:00

GiteaMirror closed this issue

2025-11-02 04:50:52 -06:00

GiteaMirror commented

2025-11-02 04:50:53 -06:00

@notgood commented on GitHub (Feb 1, 2019):

Confirming, copypasting my comment from #3727

Broken for me since today upgrade to 1.7.1.

My scenario: repo owned by organization, no forks, green compare button generates link /orgname/reponame/compare/master...MyUsername:master, which is failing horribly with 404.
Going through Pull Requests->New Pull Request generates /orgname/reponame/compare/master...master, working as expected.

@notgood commented on GitHub (Feb 1, 2019): Confirming, copypasting my comment from #3727 Broken for me since today upgrade to 1.7.1. My scenario: repo owned by organization, no forks, green compare button generates link /orgname/reponame/compare/master...MyUsername:master, which is failing horribly with 404. Going through Pull Requests->New Pull Request generates /orgname/reponame/compare/master...master, working as expected.

GiteaMirror commented

2025-11-02 04:50:53 -06:00

@zeripath commented on GitHub (Feb 1, 2019):

OK let's try to work out what the links should be. I'm struggling a little with this, I guess it should always be:

Compare the current repo and branch with the base repo and default branch.

So what was the problem in #3727 ? Well the problem is that make pull request is dependent on write access because https://github.com/go-gitea/gitea/blob/master/routers/repo/pull.go#L687 demands it.

@zeripath commented on GitHub (Feb 1, 2019): OK let's try to work out what the links should be. I'm struggling a little with this, I guess it should always be: Compare the current repo and branch with the base repo and default branch. So what was the problem in #3727 ? Well the problem is that make pull request is dependent on write access because https://github.com/go-gitea/gitea/blob/master/routers/repo/pull.go#L687 demands it.

GiteaMirror commented

2025-11-02 04:50:53 -06:00

@adelowo commented on GitHub (Feb 1, 2019):

While this is a bug, Can we actually create the fork for the user instead of throwing a 404? I think GitHub does this.

@adelowo commented on GitHub (Feb 1, 2019): While this is a bug, Can we actually create the fork for the user instead of throwing a `404`? I think GitHub does this.

GiteaMirror commented

2025-11-02 04:50:53 -06:00

@zeripath commented on GitHub (Feb 1, 2019):

Hmm. I'm actually thinking we should check perm.CanReadIssuesOrPulls(true) just like we check when creating an issue. (Despite it's name the permission to write to issues/pulls is about assigning assignees etc. not about creating them.)

@zeripath commented on GitHub (Feb 1, 2019): Hmm. I'm actually thinking we should check `perm.CanReadIssuesOrPulls(true)` just like we check when creating an issue. (Despite it's name the permission to write to issues/pulls is about assigning assignees etc. not about creating them.)

GiteaMirror commented

2025-11-02 04:50:54 -06:00

@zeripath commented on GitHub (Feb 1, 2019):

So there's a secondary issue that users cannot just type into the query field and type their own repository to move the compare to their repository.

@zeripath commented on GitHub (Feb 1, 2019): So there's a secondary issue that users cannot just type into the query field and type their own repository to move the compare to their repository.

GiteaMirror referenced this issue

2025-11-02 12:15:03 -06:00

[PR #2846] [MERGED] Clean repository ROOT directory name with filepath.Clean #16630

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#2846