Suggestion: rename "Reject" to "Request changes" (or similar) #2818

New Issue

2025-11-02T04:49:32-06:00

GiteaMirror commented

2025-11-02 04:49:32 -06:00

Originally created by @InExtremaRes on GitHub (Jan 26, 2019).

Gitea version (or commit ref): d663930
(rest is irrelevant)

Description

When reviewing a PR you can "Approve" or "Reject". The problem is that "Reject" sound too hard/rude and can hurt team relationship and confidence. Most of the time the PR is almost good but you are requesting some changes before merging, not rejecting the PR itself. GitHub, as an example, shows "Request changes" instead and I think it's a better name.

So, consider rename the "Reject" button and the "Someone rejected these changes" text to something like "Request changes" and "Someone requested changes".

Originally created by @InExtremaRes on GitHub (Jan 26, 2019). - Gitea version (or commit ref): d663930 (rest is irrelevant) ## Description When reviewing a PR you can "Approve" or "Reject". The problem is that "Reject" sound too hard/rude and can hurt team relationship and confidence. Most of the time the PR is almost good but you are requesting some changes before merging, not rejecting the PR itself. GitHub, as an example, shows "Request changes" instead and I think it's a better name. So, consider rename the "Reject" button and the "Someone rejected these changes" text to something like "Request changes" and "Someone requested changes".

GiteaMirror closed this issue

2025-11-02 04:49:32 -06:00

GiteaMirror referenced this issue

2025-11-02 12:14:37 -06:00

[PR #2818] [MERGED] Fix wrong translations #16611

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#2818