Hide whitespace in comparisons #263

New Issue

GiteaMirror · 2025-11-02T03:16:25-06:00

GiteaMirror commented

2025-11-02 03:16:25 -06:00

Originally created by @rugk on GitHub (Jan 22, 2017).

Similar to GitHub's (AFAIK) new option in comparisons (e.g. pull requests), Gitea should be able to hide the whitespace when doing comparisons (and of course to show it).
There should be a switch in the comparison view.

Upstream issue: https://github.com/gogits/gogs/issues/3795

Originally created by @rugk on GitHub (Jan 22, 2017). Similar to GitHub's (AFAIK) new option in comparisons (e.g. pull requests), Gitea should be able to hide the whitespace when doing comparisons (and of course to show it). There should be a switch in the comparison view. ![](https://cloud.githubusercontent.com/assets/11966684/19623260/37143586-98c3-11e6-8ce2-daa788d2fdc9.png) --- Upstream issue: https://github.com/gogits/gogs/issues/3795

GiteaMirror added the topic/ui type/feature issue/confirmed labels 2025-11-02 03:16:25 -06:00

GiteaMirror closed this issue

2025-11-02 03:16:25 -06:00

GiteaMirror commented

2025-11-02 03:16:26 -06:00

@bobheadxi commented on GitHub (May 16, 2018):

I think I might have a crack at this

@bobheadxi commented on GitHub (May 16, 2018): I think I might have a crack at this

GiteaMirror commented

2025-11-02 03:16:26 -06:00

@stale[bot] commented on GitHub (Jan 26, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Jan 26, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

GiteaMirror commented

2025-11-02 03:16:26 -06:00

@zeripath commented on GitHub (Jan 26, 2019):

Fixed by #4683

@zeripath commented on GitHub (Jan 26, 2019): Fixed by #4683

GiteaMirror commented

2025-11-02 03:16:26 -06:00

@PaulBol commented on GitHub (Sep 11, 2019):

I don't think that the issue is fully addressed. For a PR I see the whitespace dropdown but not for a commit. In fact it took me a while to realize this as I was sure the option existed but couldn't find it - because I was looking at a commit comparison page.

Can the issue be re-opened?

@PaulBol commented on GitHub (Sep 11, 2019): I don't think that the issue is fully addressed. For a PR I see the whitespace dropdown but not for a commit. In fact it took me a while to realize this as I was sure the option existed but couldn't find it - because I was looking at a commit comparison page. Can the issue be re-opened?

GiteaMirror commented

2025-11-02 03:16:26 -06:00

@lunny commented on GitHub (Sep 11, 2019):

You could change the options on repository settings.

@lunny commented on GitHub (Sep 11, 2019): You could change the options on repository settings.

GiteaMirror commented

2025-11-02 03:16:27 -06:00

@PaulBol commented on GitHub (Sep 11, 2019):

Thanks for your feedback. I didn't find any setting that seems to be related to the commit view. Could you please give me a hint where to look?

@PaulBol commented on GitHub (Sep 11, 2019): Thanks for your feedback. I didn't find any setting that seems to be related to the commit view. Could you please give me a hint where to look?

GiteaMirror commented

2025-11-02 03:16:27 -06:00

@e1fueg0 commented on GitHub (Oct 14, 2019):

@lunny I also can't find it, please show.

@e1fueg0 commented on GitHub (Oct 14, 2019): @lunny I also can't find it, please show.

GiteaMirror commented

2025-11-02 03:16:27 -06:00

@e1fueg0 commented on GitHub (Oct 14, 2019):

I looked into the code and found out the whitespace ignorance is only implemented for pull requests.
Please can it be implemented for regular commits @lunny ?

@e1fueg0 commented on GitHub (Oct 14, 2019): I looked into the code and found out the whitespace ignorance is only implemented for pull requests. Please can it be implemented for regular commits @lunny ?

GiteaMirror commented

2025-11-02 03:16:27 -06:00

@PaulBol commented on GitHub (Nov 8, 2019):

I must say that I didn't find the option on Github either to ignore whitespace changes on the commit view like b747501337. But I'm having troubles to see why the option exists for a pull request and not for a single commit. @rugk initially talked about comparisons in general.

@PaulBol commented on GitHub (Nov 8, 2019): I must say that I didn't find the option on Github either to ignore whitespace changes on the commit view like https://github.com/go-gitea/gitea/commit/b747501337a50b847631efe0041cf2c994f4a7fa. But I'm having troubles to see why the option exists for a pull request and not for a single commit. @rugk initially talked about comparisons in general.

GiteaMirror commented

2025-11-02 03:16:27 -06:00

@lunny commented on GitHub (Nov 9, 2019):

@e1fueg0 sorry, I missed this.

@lunny commented on GitHub (Nov 9, 2019): @e1fueg0 sorry, I missed this.

GiteaMirror commented

2025-11-02 03:16:28 -06:00

@stale[bot] commented on GitHub (Jan 8, 2020):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Jan 8, 2020): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

GiteaMirror commented

2025-11-02 03:16:28 -06:00

@maximilize commented on GitHub (Apr 27, 2022):

It seems like this feature is already implemented. However, it would be nice if the last selected option like Ignore changes in amount of whitespaces is remembered.

@maximilize commented on GitHub (Apr 27, 2022): It seems like this feature is already implemented. However, it would be nice if the last selected option like `Ignore changes in amount of whitespaces` is remembered.

GiteaMirror commented

2025-11-02 03:16:28 -06:00

@wxiaoguang commented on GitHub (Apr 27, 2022):

It seems like this feature is already implemented. However, it would be nice if the last selected option like Ignore changes in amount of whitespaces is remembered.

It is in latest 1.17

https://github.com/go-gitea/gitea/pull/15566

@wxiaoguang commented on GitHub (Apr 27, 2022): > It seems like this feature is already implemented. However, it would be nice if the last selected option like `Ignore changes in amount of whitespaces` is remembered. It is in latest 1.17 * https://github.com/go-gitea/gitea/pull/15566

GiteaMirror commented

2025-11-02 03:16:29 -06:00

@Ryuno-Ki commented on GitHub (Jun 5, 2022):

@wxiaoguang Why was this reopened?

@Ryuno-Ki commented on GitHub (Jun 5, 2022): @wxiaoguang Why was this reopened?

GiteaMirror commented

2025-11-02 03:16:29 -06:00

@wxiaoguang commented on GitHub (Jun 5, 2022):

Oh yes, it can be closed. 😊

If there is anything missing, feel free to reopen.

@wxiaoguang commented on GitHub (Jun 5, 2022): Oh yes, it can be closed. 😊 If there is anything missing, feel free to reopen.

GiteaMirror referenced this issue