github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Can't reply to review comment of deleted file #2584

New Issue
Closed
opened 2025-11-02 04:41:11 -06:00 by GiteaMirror · 2 comments
GiteaMirror commented 2025-11-02 04:41:11 -06:00
Owner
Copy Link

Originally created by @iyzana on GitHub (Nov 27, 2018).

  • Gitea version (or commit ref): 0da8bc9 / tag v1.6.0
  • Git version: 2.15.3
  • Operating system: gitea docker container
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

Steps to reproduce:

  • create a new pr, which adds a new file
  • add a review to that file
  • delete the file again
  • reply to the review comment

Repro url: https://try.gitea.io/succcubbus/review-deletion-outdated-repro/pulls/1

Expected:

  • reply is added to the review

Actual:

  • It is not possible to add a reply to the review comment
  • It causes a 500 server error
  • Relevant log (new lines on executing request):
2018/11/27 16:19:45 [D] Session ID: <redacted>
2018/11/27 16:19:45 [D] CSRF Token: <redacted>
2018/11/27 16:19:45 [.../repo/pull_review.go:80 CreateCodeComment()] [E] CreateCodeComment: LineBlame[refs/pull/115/head, /data/git/repositories/<repo-name-redacted>.git, <deleted-file-path-redacted>, 5]: exit status 128
- fatal: no such path <deleted-file-path-redacted> in refs/pull/115/head
Originally created by @iyzana on GitHub (Nov 27, 2018). <!-- 1. Please speak English, this is the language all of us can speak and write. 2. Please ask questions or configuration/deploy problems on our Discord server (https://discord.gg/NsatcWJ) or forum (https://discourse.gitea.io). 3. Please take a moment to check that your issue doesn't already exist. 4. Please give all relevant information below for bug reports, because incomplete details will be handled as an invalid report. --> - Gitea version (or commit ref): 0da8bc9 / tag v1.6.0 - Git version: 2.15.3 - Operating system: gitea docker container - Database (use `[x]`): - [ ] PostgreSQL - [ ] MySQL - [ ] MSSQL - [x] SQLite - Can you reproduce the bug at https://try.gitea.io: - [x] Yes (provide example URL) - [ ] No - [ ] Not relevant - Log gist: ## Description Steps to reproduce: - create a new pr, which adds a new file - add a review to that file - delete the file again - reply to the review comment Repro url: https://try.gitea.io/succcubbus/review-deletion-outdated-repro/pulls/1 Expected: - reply is added to the review Actual: - It is not possible to add a reply to the review comment - It causes a 500 server error - Relevant log (new lines on executing request): ``` 2018/11/27 16:19:45 [D] Session ID: <redacted> 2018/11/27 16:19:45 [D] CSRF Token: <redacted> 2018/11/27 16:19:45 [.../repo/pull_review.go:80 CreateCodeComment()] [E] CreateCodeComment: LineBlame[refs/pull/115/head, /data/git/repositories/<repo-name-redacted>.git, <deleted-file-path-redacted>, 5]: exit status 128 - fatal: no such path <deleted-file-path-redacted> in refs/pull/115/head ```
GiteaMirror added the issue/confirmedtype/bug labels 2025-11-02 04:41:11 -06:00
GiteaMirror commented 2025-11-02 04:41:12 -06:00
Author
Owner
Copy Link

@stale[bot] commented on GitHub (Jan 26, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Jan 26, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.
GiteaMirror commented 2025-11-02 04:41:12 -06:00
Author
Owner
Copy Link

@adelowo commented on GitHub (Jan 28, 2019):

This is a valid bug.

@adelowo commented on GitHub (Jan 28, 2019): This is a valid bug.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/confirmed type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#2584
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?