github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 10:39:38 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

XSS in PR review comments #2575

New Issue
Closed
opened 2025-11-02 04:40:56 -06:00 by GiteaMirror · 1 comment
GiteaMirror commented 2025-11-02 04:40:56 -06:00
Owner
Copy Link

Originally created by @Aragur on GitHub (Nov 26, 2018).

  • Gitea version (or commit ref): 0dcf31a
  • Git version: not relevant
  • Operating system: not relevant
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

The review comment screen allows XSS. (Doesn't sanitize input)

Screenshots

image

Originally created by @Aragur on GitHub (Nov 26, 2018). <!-- 1. Please speak English, this is the language all of us can speak and write. 2. Please ask questions or configuration/deploy problems on our Discord server (https://discord.gg/NsatcWJ) or forum (https://discourse.gitea.io). 3. Please take a moment to check that your issue doesn't already exist. 4. Please give all relevant information below for bug reports, because incomplete details will be handled as an invalid report. --> - Gitea version (or commit ref): 0dcf31a - Git version: not relevant - Operating system: not relevant - Database (use `[x]`): - [ ] PostgreSQL - [X] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [X] Not relevant - Log gist: ## Description The review comment screen allows XSS. (Doesn't sanitize input) ## Screenshots ![image](https://user-images.githubusercontent.com/11004008/49023943-9ca23800-f198-11e8-9194-977bbf273ed7.png) <!-- **If this issue involves the Web Interface, please include a screenshot** -->
GiteaMirror added the topic/securityreviewed/wontfix labels 2025-11-02 04:40:56 -06:00
GiteaMirror commented 2025-11-02 04:40:57 -06:00
Author
Owner
Copy Link

@jonasfranz commented on GitHub (Nov 27, 2018):

Thank you for reporting, but I think that this is not a XSS since <h1> etc. are valid markdown stylings. I've tested it for malicious code like iFrames or JS. These get filtered out like normal comment. There is no difference between the santization of comments and PR comments.

Please reopen if you've another opinion.

@jonasfranz commented on GitHub (Nov 27, 2018): Thank you for reporting, but I think that this is not a XSS since `<h1>` etc. are valid markdown stylings. I've tested it for malicious code like iFrames or JS. These get filtered out like normal comment. There is no difference between the santization of comments and PR comments. Please reopen if you've another opinion.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label reviewed/wontfix topic/security
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#2575
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?