github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 10:39:38 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Rework log rotation #2498

New Issue
Closed
opened 2025-11-02 04:38:36 -06:00 by GiteaMirror · 2 comments
GiteaMirror commented 2025-11-02 04:38:36 -06:00
Owner
Copy Link

Originally created by @micw on GitHub (Nov 6, 2018).

Currently, log rotation in gitea is done implicitly in the file logger when log files exceeds a given age or size. This can cause race condition on "serv" commands where multiple processes write to the same logfile.
Example:
2 serv commands are started, read the logfile size which is close to maximum size and write a log line. Now both processes will rotate the logs.

We should either
a) rework log rotation so that is handled by the long-running server process
b) remove log rotation entirely from gitea and use "logrotate" on the docker images.
or
c) remove file logging entirely from gitea and use the sysem's logging infrastructure (syslog, systemd-journal or such)

Originally created by @micw on GitHub (Nov 6, 2018). Currently, log rotation in gitea is done implicitly in the file logger when log files exceeds a given age or size. This can cause race condition on "serv" commands where multiple processes write to the same logfile. Example: 2 serv commands are started, read the logfile size which is close to maximum size and write a log line. Now both processes will rotate the logs. We should either a) rework log rotation so that is handled by the long-running server process b) remove log rotation entirely from gitea and use "logrotate" on the docker images. or c) remove file logging entirely from gitea and use the sysem's logging infrastructure (syslog, systemd-journal or such)
GiteaMirror added the type/proposal label 2025-11-02 04:38:36 -06:00
GiteaMirror commented 2025-11-02 04:38:37 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Nov 7, 2018):

I think we could use another matured log library to maintain a this one.

@lunny commented on GitHub (Nov 7, 2018): I think we could use another matured log library to maintain a this one.
GiteaMirror commented 2025-11-02 04:38:37 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Jun 6, 2020):

I'm going to close this as we no longer write to the serv.log.

@zeripath commented on GitHub (Jun 6, 2020): I'm going to close this as we no longer write to the serv.log.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/proposal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#2498
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?