Implement Pull Requests history #2480

Closed
opened 2025-11-02 04:37:57 -06:00 by GiteaMirror · 8 comments
Owner

Originally created by @iddm on GitHub (Nov 2, 2018).

It would be nice to have history of changes in the pull requests as it is in gitlab, for example: if someone pushes commit with force, it would be nice to have diff of what was before this push, so, probably, we should store changes for that and notify user on each push event as in gitlab.

Originally created by @iddm on GitHub (Nov 2, 2018). It would be nice to have history of changes in the pull requests as it is in gitlab, for example: if someone pushes commit with `force`, it would be nice to have diff of what was before this push, so, probably, we should store changes for that and notify user on each push event as in gitlab.
GiteaMirror added the type/proposal label 2025-11-02 04:37:57 -06:00
Author
Owner

@singalen commented on GitHub (Jan 18, 2019):

Rebase and force-push is a natural workflow of PR that is not accepted immediately.
Of course, one could close one PR and open another one, but it would be much better to keep a history of PR and its reviews.

@singalen commented on GitHub (Jan 18, 2019): Rebase and force-push is a natural workflow of PR that is not accepted immediately. Of course, one could close one PR and open another one, but it would be much better to keep a history of PR and its reviews.
Author
Owner

@lafriks commented on GitHub (Jan 22, 2019):

Do you have any suggestions on how to store it git repository?

@lafriks commented on GitHub (Jan 22, 2019): Do you have any suggestions on how to store it git repository?
Author
Owner

@iddm commented on GitHub (Apr 19, 2019):

@lafriks I am not sure I understand what you were saying.

@iddm commented on GitHub (Apr 19, 2019): @lafriks I am not sure I understand what you were saying.
Author
Owner

@lafriks commented on GitHub (Apr 23, 2019):

I asked if anyone has ideas on how to store/get previous changes that have been removed from branch by force push

@lafriks commented on GitHub (Apr 23, 2019): I asked if anyone has ideas on how to store/get previous changes that have been removed from branch by force push
Author
Owner

@iddm commented on GitHub (Apr 23, 2019):

What about storing them in the gitea's database?

@iddm commented on GitHub (Apr 23, 2019): What about storing them in the gitea's database?
Author
Owner

@singalen commented on GitHub (Apr 23, 2019):

The question is about the record format, I believe.
I don't have the experience with git database format, but gerrit or gitlab formats should do.

Particularly, each PR version can be saved as a hidden branch; the comments to the commits would be stored the way they are now.
You may even want to reimplement gerrit's master feature: use or calculate a mapping between different versions of same commit across PR versions in Change-Id: field, and display a history of a commit.

@singalen commented on GitHub (Apr 23, 2019): The question is about the record format, I believe. I don't have the experience with git database format, but gerrit or gitlab formats should do. Particularly, each PR version can be saved as a hidden branch; the comments to the commits would be stored the way they are now. You may even want to reimplement gerrit's master feature: use or calculate a mapping between different versions of same commit across PR versions in `Change-Id:` field, and display a history of a **commit**.
Author
Owner

@ghost commented on GitHub (Aug 31, 2020):

Actually I just discovered this issue. I think this is the same as the one I opened: #12604.

The related work in progress pull request is: #12665

@ghost commented on GitHub (Aug 31, 2020): Actually I just discovered this issue. I think this is the same as the one I opened: #12604. The related work in progress pull request is: #12665
Author
Owner

@singalen commented on GitHub (Aug 31, 2020):

Yay, thanks a ton!

@singalen commented on GitHub (Aug 31, 2020): Yay, thanks a ton!
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#2480