OAuth-created Accounts cannot be unlinked #2382

Closed
opened 2025-11-02 04:34:21 -06:00 by GiteaMirror · 2 comments
Owner

Originally created by @coolaj86 on GitHub (Oct 7, 2018).

While reviewing the code I found that OAuth-created accounts are treated differently than oauth-linked accounts.

Currently under Manage account links (/user/settings/security) they cannot be unlinked from the oauth provider that created them, despite having their own username and email address.

I believe this is the desired behavior when ALLOW_ONLY_EXTERNAL_REGISTRATION is set, but should probably not be the behavior generally.

I'll include the fix in with another related PR, but I wanted to document it separately here for now.

Originally created by @coolaj86 on GitHub (Oct 7, 2018). While reviewing the code I found that OAuth-created accounts are treated differently than oauth-linked accounts. Currently under **Manage account links** (`/user/settings/security`) they cannot be unlinked from the oauth provider that created them, despite having their own username and email address. I believe this is the desired behavior when `ALLOW_ONLY_EXTERNAL_REGISTRATION` is set, but should probably not be the behavior generally. I'll include the fix in with another related PR, but I wanted to document it separately here for now. <!-- * [x] link oauth-created accounts just like normal ones * exception: `ALLOW_ONLY_EXTERNAL_REGISTRATION` * [x] `remember me` on sign up page * [x] do not require a second login when account is created * [ ] allow setting password if none is set * [ ] be clear that the user should use api key for https password -->
GiteaMirror added the type/enhancementissue/stale labels 2025-11-02 04:34:21 -06:00
Author
Owner

@stale[bot] commented on GitHub (Jan 7, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Jan 7, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.
Author
Owner

@stale[bot] commented on GitHub (Feb 22, 2019):

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale[bot] commented on GitHub (Feb 22, 2019): This issue has been automatically closed because of inactivity. You can re-open it if needed.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#2382