Adding a single-line code review comment does not send an email notification. #2376

New Issue

GiteaMirror · 2025-11-02T04:34:13-06:00

GiteaMirror commented

2025-11-02 04:34:13 -06:00

Originally created by @mkienenb on GitHub (Oct 4, 2018).

Gitea version (or commit ref):

/var/lib/gitea>sudo /usr/local/bin/gitea --version
Gitea version 36e7cb9 built with: bindata, sqlite
[master snapshot grabbed Sept 24]

Git version:
git version 2.18.0
Operating system:
CentOS release 6.4 (Final)
Database (use [x]):
- PostgreSQL
- MySQL
- MSSQL
- SQLite
Can you reproduce the bug at https://try.gitea.io:
- Yes (provide example URL)
- No
- Not relevant
- Very likely, but I couldn't turn up an example PR to comment on right away.

Description

Adding a single-line comment does not send an email notification.

Create PR including deleted file
Click "Files changed"
Click "+" on any line of a deleted file.
Enter a single-line comment.

Expectation: Email sent with new comment.
Actual: No email sent.

Originally created by @mkienenb on GitHub (Oct 4, 2018). Gitea version (or commit ref): /var/lib/gitea>sudo /usr/local/bin/gitea --version Gitea version 36e7cb9 built with: bindata, sqlite [master snapshot grabbed Sept 24] - Git version: git version 2.18.0 - Operating system: CentOS release 6.4 (Final) - Database (use `[x]`): - [ ] PostgreSQL - [ ] MySQL - [ ] MSSQL - [x] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [ ] Not relevant - [x] Very likely, but I couldn't turn up an example PR to comment on right away. ## Description Adding a single-line comment does not send an email notification. 1) Create PR including deleted file 2) Click "Files changed" 3) Click "+" on any line of a deleted file. 4) Enter a single-line comment. Expectation: Email sent with new comment. Actual: No email sent.

GiteaMirror closed this issue

2025-11-02 04:34:13 -06:00

GiteaMirror commented

2025-11-02 04:34:14 -06:00

@mkienenb commented on GitHub (Oct 4, 2018):

Hmm. False alarm? Seems to be working now, although I had another user have the same issue yesterday. Since I can't reproduce, I'll close it for now.

@mkienenb commented on GitHub (Oct 4, 2018): Hmm. False alarm? Seems to be working now, although I had another user have the same issue yesterday. Since I can't reproduce, I'll close it for now.

GiteaMirror referenced this issue

2025-11-02 12:09:05 -06:00

[PR #2376] [MERGED] Fix "index out of range" runtime error in repo_list tests #16372

GiteaMirror referenced this issue

2025-11-02 12:09:12 -06:00

[PR #2381] [MERGED] Fix tests code to prevent some runtime errors #16376

Sign in to join this conversation.