Upgrade gopkg.in/testfixtures.v2 #2368

Closed
opened 2025-11-02 04:33:57 -06:00 by GiteaMirror · 3 comments
Owner

Originally created by @typeless on GitHub (Oct 2, 2018).

Encountered a deadlock while working on #2040

See https://github.com/go-gitea/gitea/blob/master/vendor/gopkg.in/testfixtures.v2/sqlite.go#L25-L40
tx.Rollback is missing. It has been fixed upstream.
I cannot find the document about upgrading the vendored packages. It used to be govendor. I am not sure about the current approach so here is the issue. Hopefully you guys could help.

Originally created by @typeless on GitHub (Oct 2, 2018). Encountered a deadlock while working on #2040 See https://github.com/go-gitea/gitea/blob/master/vendor/gopkg.in/testfixtures.v2/sqlite.go#L25-L40 `tx.Rollback` is missing. It has been fixed upstream. I cannot find the document about upgrading the vendored packages. It used to be govendor. I am not sure about the current approach so here is the issue. Hopefully you guys could help.
Author
Owner

@adelowo commented on GitHub (Oct 2, 2018):

make vendor b8d048fa0d/Makefile (L176)

@adelowo commented on GitHub (Oct 2, 2018): `make vendor` https://github.com/go-gitea/gitea/blob/b8d048fa0d2cdd0781051990d34cb3681a8ae114/Makefile#L176
Author
Owner

@typeless commented on GitHub (Oct 2, 2018):

@adelowo Thanks for the hint. I am looking up dep now.

hmm ... make vendor has been hanging for quite a while. Is that normal? I should have added -v 😆

@typeless commented on GitHub (Oct 2, 2018): @adelowo Thanks for the hint. I am looking up dep now. hmm ... `make vendor` has been hanging for quite a while. Is that normal? I should have added `-v` 😆
Author
Owner

@adelowo commented on GitHub (Oct 2, 2018):

hmm ... make vendor has been hanging for quite a while. Is that normal? I should have added -v 😆

Usually slow on my end too but I think it's my internet connection

@adelowo commented on GitHub (Oct 2, 2018): > hmm ... `make vendor` has been hanging for quite a while. Is that normal? I should have added `-v` 😆 Usually slow on my end too but I think it's my internet connection
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#2368