github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-14 03:46:23 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

hostname/DOMAIN used as subpath in templates somehow? #2322

New Issue
Closed
opened 2025-11-02 04:32:47 -06:00 by GiteaMirror · 12 comments
GiteaMirror commented 2025-11-02 04:32:47 -06:00
Owner
Copy Link

Originally created by @ghost on GitHub (Sep 12, 2018).

  • Gitea version (or commit ref): docker - gitea/gitea:latest
  • Git version:
  • Operating system:
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant (deals with custom config)
  • Log gist:
gitea_1       | [Macaron] 2018-09-12 04:24:44: Started GET / for 172.68.143.94
gitea_1       | [Macaron] 2018-09-12 04:24:44: Completed GET / 200 OK in 3.83089ms
gitea_1       | [Macaron] 2018-09-12 04:24:45: Started GET /git.me.host/vendor/assets/octicons/octicons.min.css for 172.68.143.94
gitea_1       | [Macaron] 2018-09-12 04:24:45: Completed GET /git.me.host/vendor/assets/octicons/octicons.min.css 404 Not Found in 4.221723ms
gitea_1

Description

Gitea seems to be using the hostname (defined in ini as DOMAIN) to decide on the addresses for templates as a suburl, when used behind Traefik. I'm unsure if this is still the trailing slash issue
encountered on nginx.

Based on the separated templates (using the AppSubUrl variable in templates/base.tmpl) from 5 days ago, maybe it's just that it's broken there?

Or maybe it's still just that gitea acts weird around trailing slashes (...why... does it still do this?) 😢

why would it gobble domain into the templates?

Originally created by @ghost on GitHub (Sep 12, 2018). - Gitea version (or commit ref): docker - gitea/gitea:latest - Git version: - Operating system: - Database (use `[x]`): - [ ] PostgreSQL - [ ] MySQL - [ ] MSSQL - [x] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [x] Not relevant (deals with custom config) - Log gist: ``` gitea_1 | [Macaron] 2018-09-12 04:24:44: Started GET / for 172.68.143.94 gitea_1 | [Macaron] 2018-09-12 04:24:44: Completed GET / 200 OK in 3.83089ms gitea_1 | [Macaron] 2018-09-12 04:24:45: Started GET /git.me.host/vendor/assets/octicons/octicons.min.css for 172.68.143.94 gitea_1 | [Macaron] 2018-09-12 04:24:45: Completed GET /git.me.host/vendor/assets/octicons/octicons.min.css 404 Not Found in 4.221723ms gitea_1 ``` ## Description Gitea seems to be using the hostname (defined in ini as DOMAIN) to decide on the addresses for templates as a suburl, when used behind Traefik. I'm unsure if this is still the trailing slash issue encountered on nginx. Based on the separated templates (using the AppSubUrl variable in templates/base.tmpl) from 5 days ago, maybe it's just that it's broken there? Or maybe it's still just that gitea acts weird around trailing slashes (...why... does it still do this?) :cry: why would it gobble domain into the templates?
GiteaMirror added the issue/confirmed label 2025-11-02 04:32:47 -06:00
GiteaMirror commented 2025-11-02 04:32:48 -06:00
Author
Owner
Copy Link

@lafriks commented on GitHub (Sep 12, 2018):

Can you provide parts of app.ini about domain/subpath/appurl?

@lafriks commented on GitHub (Sep 12, 2018): Can you provide parts of app.ini about domain/subpath/appurl?
GiteaMirror commented 2025-11-02 04:32:48 -06:00
Author
Owner
Copy Link

@ghost commented on GitHub (Sep 12, 2018):

used the example ini, changing the domain and setting DB type to sqlite.

[server]
; The protocol the server listens on. One of 'http', 'https', 'unix' or 'fcgi'.
PROTOCOL = http
DOMAIN = git.me.host
ROOT_URL = %(PROTOCOL)s://%(DOMAIN)s:%(HTTP_PORT)s/
; The address to listen on. Either a IPv4/IPv6 address or the path to a unix socket.
HTTP_ADDR = 0.0.0.0
HTTP_PORT = 3000

...

DB_Type=sqlite3
@ghost commented on GitHub (Sep 12, 2018): used the example ini, changing the domain and setting DB type to sqlite. ``` [server] ; The protocol the server listens on. One of 'http', 'https', 'unix' or 'fcgi'. PROTOCOL = http DOMAIN = git.me.host ROOT_URL = %(PROTOCOL)s://%(DOMAIN)s:%(HTTP_PORT)s/ ; The address to listen on. Either a IPv4/IPv6 address or the path to a unix socket. HTTP_ADDR = 0.0.0.0 HTTP_PORT = 3000 ... DB_Type=sqlite3 ```
GiteaMirror commented 2025-11-02 04:32:48 -06:00
Author
Owner
Copy Link

@lafriks commented on GitHub (Sep 12, 2018):

app.ini looks good. Can you check what paths are in rendered html when you view source from browser when opening page?

@lafriks commented on GitHub (Sep 12, 2018): app.ini looks good. Can you check what paths are in rendered html when you view source from browser when opening page?
GiteaMirror commented 2025-11-02 04:32:48 -06:00
Author
Owner
Copy Link

@ghost commented on GitHub (Sep 12, 2018):

<link rel="stylesheet" href="git.me.host/vendor/plugins/semantic/semantic.min.css">
	<link rel="stylesheet" href="git.me.host/css/index.css?v=69c0cd75067b7801ae667465a9ee03c3">
@ghost commented on GitHub (Sep 12, 2018): ``` <link rel="stylesheet" href="git.me.host/vendor/plugins/semantic/semantic.min.css"> <link rel="stylesheet" href="git.me.host/css/index.css?v=69c0cd75067b7801ae667465a9ee03c3"> ```
GiteaMirror commented 2025-11-02 04:32:49 -06:00
Author
Owner
Copy Link

@ghost commented on GitHub (Sep 12, 2018):

could just be templating not prefixing the url with /? or should that be in the config, prefixed there?

@ghost commented on GitHub (Sep 12, 2018): could just be templating not prefixing the url with /? or should that be in the config, prefixed there?
GiteaMirror commented 2025-11-02 04:32:49 -06:00
Author
Owner
Copy Link

@ghost commented on GitHub (Sep 12, 2018):

(ref="domain/assets" instead of, i.e. "https://domain/assets", or "/domain/assets")

@ghost commented on GitHub (Sep 12, 2018): (ref="domain/assets" instead of, i.e. "https://domain/assets", or "/domain/assets")
GiteaMirror commented 2025-11-02 04:32:49 -06:00
Author
Owner
Copy Link

@lafriks commented on GitHub (Sep 12, 2018):

It should not include domain part at all

@lafriks commented on GitHub (Sep 12, 2018): It should not include domain part at all
GiteaMirror commented 2025-11-02 04:32:49 -06:00
Author
Owner
Copy Link

@ghost commented on GitHub (Sep 12, 2018):

I'm headed off to bed. Thank you @lafriks for helping out so far :)

@ghost commented on GitHub (Sep 12, 2018): I'm headed off to bed. Thank you @lafriks for helping out so far :)
GiteaMirror commented 2025-11-02 04:32:49 -06:00
Author
Owner
Copy Link

@stale[bot] commented on GitHub (Jan 10, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Jan 10, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.
GiteaMirror commented 2025-11-02 04:32:50 -06:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 10, 2019):

I'll check to see if this issue still exists...

@ghost commented on GitHub (Jan 10, 2019): I'll check to see if this issue still exists...
GiteaMirror commented 2025-11-02 04:32:50 -06:00
Author
Owner
Copy Link

@stale[bot] commented on GitHub (Mar 11, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Mar 11, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.
GiteaMirror commented 2025-11-02 04:32:50 -06:00
Author
Owner
Copy Link

@mrsdizzie commented on GitHub (Sep 8, 2020):

Does not seem reproducible in current version

@mrsdizzie commented on GitHub (Sep 8, 2020): Does not seem reproducible in current version
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/confirmed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#2322
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?