Accentued chars in tags (under project description) #2290

Closed
opened 2025-11-02 04:31:21 -06:00 by GiteaMirror · 8 comments
Owner

Originally created by @blankoworld on GitHub (Sep 3, 2018).

Gitea version

  • Gitea version (or commit ref): 1.5.0 built with: bindata, sqlite, tidb, pam
  • Git version: 2.18.0
  • Operating system: ArchLinux
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:

Description

  • Use an existing project, or create a new one
  • Push some files (if new one to access to project description)
  • Click on "manage tags" (in French « Gérer les sujets »)
  • Add "vidéo" as tag, then click on "finish" button (in French « Terminé »)
  • The web interface ask to use a tag that start with a number or a char, etc.

Screenshots

2018-09-03-1536004939_screenshot_1680x1050

Originally created by @blankoworld on GitHub (Sep 3, 2018). Gitea version - Gitea version (or commit ref): 1.5.0 built with: bindata, sqlite, tidb, pam - Git version: 2.18.0 - Operating system: ArchLinux - Database (use `[x]`): - [x] PostgreSQL - [ ] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [x] Yes (provide example URL): https://try.gitea.io/bl4n/test (attempt to add tags with accentued chars without any result). - [ ] No - [ ] Not relevant ## Description * Use an existing project, or create a new one * Push some files (if new one to access to project description) * Click on "manage tags" (in French « Gérer les sujets ») * Add "vidéo" as tag, then click on "finish" button (in French « Terminé ») * The web interface ask to use a tag that start with a number or a char, etc. ## Screenshots ![2018-09-03-1536004939_screenshot_1680x1050](https://user-images.githubusercontent.com/147417/45000426-0f9a7900-afc5-11e8-8cc3-9fb3fe5b3739.jpg)
GiteaMirror added the type/enhancement label 2025-11-02 04:31:21 -06:00
Author
Owner

@lafriks commented on GitHub (Sep 12, 2018):

It is intended behavior to allow only English characters and I don't think topics should allow non-ascii characters. (GitHub also does not allow that)

@lafriks commented on GitHub (Sep 12, 2018): It is intended behavior to allow only English characters and I don't think topics should allow non-ascii characters. (GitHub also does not allow that)
Author
Owner

@blankoworld commented on GitHub (Sep 12, 2018):

Ok, I understand.
So I suggest to add a better explanation. Because I do what's defined in the message: only chars and number.
And this message does not ask that space are forbidden (if they are).

Could we change the message?

@blankoworld commented on GitHub (Sep 12, 2018): Ok, I understand. So I suggest to add a better explanation. Because I do what's defined in the message: only chars and number. And this message does not ask that space are forbidden (if they are). Could we change the message?
Author
Owner

@lafriks commented on GitHub (Sep 12, 2018):

Sure any recommendations what that message should look like?

@lafriks commented on GitHub (Sep 12, 2018): Sure any recommendations what that message should look like?
Author
Owner

@blankoworld commented on GitHub (Sep 12, 2018):

In fact neither spaces nor special chars are allowed.

So I suggest something like:

Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long. Spaces and special chars are not allowed.

or to have less chars:

Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long. Dismiss spaces and special chars.

In french, it would be respectively:

Les noms de sujets doivent commencer par une lettre ou un nombre, peuvent contenir des tirets ('-') et peuvent comporter jusqu'à 35 caractères. Les espaces et les caractères spéciaux ne sont pas autorisés.

or:

Les noms de sujets doivent commencer par une lettre ou un nombre, peuvent contenir des tirets ('-') et peuvent comporter jusqu'à 35 caractères. Évitez les espaces et les caractères spéciaux.

You can adapt the sentence because I'm french native. Not english one ^_^

@blankoworld commented on GitHub (Sep 12, 2018): In fact neither spaces nor special chars are allowed. So I suggest something like: ``` Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long. Spaces and special chars are not allowed. ``` or to have less chars: ``` Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long. Dismiss spaces and special chars. ``` In french, it would be respectively: ``` Les noms de sujets doivent commencer par une lettre ou un nombre, peuvent contenir des tirets ('-') et peuvent comporter jusqu'à 35 caractères. Les espaces et les caractères spéciaux ne sont pas autorisés. ``` or: ``` Les noms de sujets doivent commencer par une lettre ou un nombre, peuvent contenir des tirets ('-') et peuvent comporter jusqu'à 35 caractères. Évitez les espaces et les caractères spéciaux. ``` You can adapt the sentence because I'm french native. Not english one ^_^
Author
Owner

@stale[bot] commented on GitHub (Jan 9, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Jan 9, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.
Author
Owner

@blankoworld commented on GitHub (Jan 9, 2019):

Tell me where to change messages and I can suggest a pull request, can't it?

@blankoworld commented on GitHub (Jan 9, 2019): Tell me where to change messages and I can suggest a pull request, can't it?
Author
Owner

@apricote commented on GitHub (Jan 9, 2019):

The english message is defined here: https://github.com/go-gitea/gitea/blob/master/options/locale/locale_en-US.ini#L1255

You can adjust this line and create a PR.

The french translation is managed through Crowdin, you need to suggest the change there.

@apricote commented on GitHub (Jan 9, 2019): The english message is defined here: https://github.com/go-gitea/gitea/blob/master/options/locale/locale_en-US.ini#L1255 You can adjust this line and create a PR. The french translation is managed through Crowdin, you need to suggest the change there.
Author
Owner

@techknowlogick commented on GitHub (Jan 9, 2019):

Thanks for responding @apricote. @blankoworld see above for where translations are made.

Closing this ticket now

@techknowlogick commented on GitHub (Jan 9, 2019): Thanks for responding @apricote. @blankoworld see above for where translations are made. Closing this ticket now
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#2290