Mail module should add an option to explicitly decide using tls or not. #2266

New Issue

GiteaMirror · 2025-11-02T04:30:25-06:00

GiteaMirror commented

2025-11-02 04:30:25 -06:00

Originally created by @simonwu-os on GitHub (Aug 29, 2018).

Dear All,
in the module gitea/modules/mailer/mailer.go, there is a fragment to decide it using tls or not.
isSecureConn := false
// Start TLS directly if the port ends with 465 (SMTPS protocol)
if strings.HasSuffix(port, "465") {
conn = tls.Client(conn, tlsconfig)
isSecureConn = true
}
It says that the port should suffix with '465'. we have a problem it, because we use a smtp which using the port 946 for tls connect. So I suggest add an option in the mail config to support tls connect explicitly.
Thanks very much.

Originally created by @simonwu-os on GitHub (Aug 29, 2018). Dear All, in the module gitea/modules/mailer/mailer.go, there is a fragment to decide it using tls or not. isSecureConn := false // Start TLS directly if the port ends with 465 (SMTPS protocol) if strings.HasSuffix(port, "465") { conn = tls.Client(conn, tlsconfig) isSecureConn = true } It says that the port should suffix with '465'. we have a problem it, because we use a smtp which using the port 946 for tls connect. So I suggest add an option in the mail config to support tls connect explicitly. Thanks very much.

GiteaMirror added the type/enhancement label 2025-11-02 04:30:25 -06:00

GiteaMirror closed this issue

2025-11-02 04:30:26 -06:00

GiteaMirror referenced this issue

2025-11-02 12:07:32 -06:00

[PR #2266] [MERGED] Only check at least one email gpg key #16316

GiteaMirror referenced this issue

2025-11-02 12:10:06 -06:00

[PR #2467] [MERGED] Make repo private to not interfere with other tests #16415

GiteaMirror referenced this issue

2025-11-02 12:14:14 -06:00

[PR #2788] [MERGED] Backport to v1.2 of PR 2266 2467 2663 #16594