URLs not show correct in rendered content for issue and wiki page #2262

New Issue

2025-11-02T04:30:12-06:00

GiteaMirror commented

2025-11-02 04:30:12 -06:00

Originally created by @webjoel on GitHub (Aug 28, 2018).

Gitea version (or commit ref): 34831af
Database (use [x]):
- PostgreSQL
Can you reproduce the bug at https://try.gitea.io:
- Yes (https://try.gitea.io/webjoel_test_user/test_url)

Description

URLs not show correct in rendered content for issue and wiki page.

Screenshots

Originally created by @webjoel on GitHub (Aug 28, 2018). - Gitea version (or commit ref): 34831af - Database (use `[x]`): - [x] PostgreSQL - Can you reproduce the bug at https://try.gitea.io: - [x] Yes (https://try.gitea.io/webjoel_test_user/test_url) ## Description URLs not show correct in rendered content for issue and wiki page. ## Screenshots ![issue_comment](https://user-images.githubusercontent.com/1946348/44727714-10a54500-aab1-11e8-8cd3-befc1fd0d34c.png) ![wiki](https://user-images.githubusercontent.com/1946348/44727890-7a255380-aab1-11e8-8cb7-a2dfaec5eb17.png)

GiteaMirror added the issue/confirmed type/bug labels 2025-11-02 04:30:12 -06:00

GiteaMirror closed this issue

2025-11-02 04:30:12 -06:00

GiteaMirror commented

2025-11-02 04:30:13 -06:00

@lunny commented on GitHub (Aug 28, 2018):

~~It seems https://try.gitea.io/webjoel_test_user/test_url is blank.~~

@lunny commented on GitHub (Aug 28, 2018): ~It seems https://try.gitea.io/webjoel_test_user/test_url is blank.~

GiteaMirror commented

2025-11-02 04:30:14 -06:00

@webjoel commented on GitHub (Aug 28, 2018):

@lunny click in Issue page and wiki page. Not access?

@webjoel commented on GitHub (Aug 28, 2018): @lunny click in Issue page and wiki page. Not access?

GiteaMirror commented

2025-11-02 04:30:14 -06:00

@webjoel commented on GitHub (Aug 28, 2018):

Related to #2260 ?

@webjoel commented on GitHub (Aug 28, 2018): Related to #2260 ?

GiteaMirror commented

2025-11-02 04:30:14 -06:00

@lunny commented on GitHub (Aug 29, 2018):

I can see it in the wiki

@lunny commented on GitHub (Aug 29, 2018): I can see it in the wiki

GiteaMirror commented

2025-11-02 04:30:14 -06:00

@stale[bot] commented on GitHub (Jan 12, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Jan 12, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

GiteaMirror commented

2025-11-02 04:30:15 -06:00

@webjoel commented on GitHub (Jan 14, 2019):

Not possible see problem?

https://try.gitea.io/webjoel_test_user/test_url/wiki/

@webjoel commented on GitHub (Jan 14, 2019): Not possible see problem? https://try.gitea.io/webjoel_test_user/test_url/wiki/

GiteaMirror commented

2025-11-02 04:30:15 -06:00

@stale[bot] commented on GitHub (Mar 26, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Mar 26, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

GiteaMirror commented

2025-11-02 04:30:15 -06:00

@webjoel commented on GitHub (Mar 26, 2019):

??

@webjoel commented on GitHub (Mar 26, 2019): ??

GiteaMirror commented

2025-11-02 04:30:16 -06:00

@mrsdizzie commented on GitHub (Mar 27, 2019):

This happens because we run the sha1CurrentPattern processor first before the linkProcessor and wrongly picking up the numbers in https://stackoverflow.com/questions/44203982/why-is-android-o-failing-with-does-not-belong-to-this-fragmentmanageras a commit hash. The general linkProcessor should probably run after we look for specific links (full commit/issue/etc...) but before we start looking for more generic patterns. That would fix this particular issue.

Also sha1CurrentPattern is broken if it is hijacking that link above based on the numbers. It should probably only trigger if the patter exists on its own and not within another string. Will investigate/PR for this.

@mrsdizzie commented on GitHub (Mar 27, 2019): This happens because we run the sha1CurrentPattern processor first before the linkProcessor and wrongly picking up the numbers in ```https://stackoverflow.com/questions/44203982/why-is-android-o-failing-with-does-not-belong-to-this-fragmentmanager```as a commit hash. The general linkProcessor should probably run after we look for specific links (full commit/issue/etc...) but before we start looking for more generic patterns. That would fix this particular issue. Also sha1CurrentPattern is broken if it is hijacking that link above based on the numbers. It should probably only trigger if the patter exists on its own and not within another string. Will investigate/PR for this.

GiteaMirror referenced this issue

2025-11-02 12:07:26 -06:00

[PR #2262] [MERGED] update drone sig file. #16313

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#2262