Cannot comment in split diff view #2219

New Issue

GiteaMirror · 2025-11-02T04:27:55-06:00

GiteaMirror commented

2025-11-02 04:27:55 -06:00

Originally created by @jonasfranz on GitHub (Aug 19, 2018).

Gitea version (or commit ref): b1ad573
Can you reproduce the bug at https://try.gitea.io:
- Yes: https://try.gitea.io/go-gitea/chardet/pulls/1/files?style=split&whitespace=

Description

~~It is not possible to add new comments in split diff view because the '+'-button does not show up~~ Resolved by error on trying to show wiki page (#5038)
It is not possible to submit a comment at an existing conversation.

Originally created by @jonasfranz on GitHub (Aug 19, 2018). - Gitea version (or commit ref): b1ad573 - Can you reproduce the bug at https://try.gitea.io: - [x] Yes: https://try.gitea.io/go-gitea/chardet/pulls/1/files?style=split&whitespace= ## Description 1. ~~It is not possible to add new comments in split diff view because the '+'-button does not show up~~ Resolved by #5038 2. It is not possible to submit a comment at an existing conversation.

GiteaMirror added the issue/confirmed topic/ui type/bug labels 2025-11-02 04:27:55 -06:00

GiteaMirror closed this issue

2025-11-02 04:27:56 -06:00

GiteaMirror commented

2025-11-02 04:27:57 -06:00

@jonasfranz commented on GitHub (Oct 9, 2018):

Reopen since 2. is not resolved.

@jonasfranz commented on GitHub (Oct 9, 2018): Reopen since 2. is not resolved.

GiteaMirror commented

2025-11-02 04:27:58 -06:00

@lunny commented on GitHub (Dec 12, 2018):

@JonasFranzDEV I think this should be an enhancement but not a bug. And moving it to v1.7 is better.

@lunny commented on GitHub (Dec 12, 2018): @JonasFranzDEV I think this should be an enhancement but not a bug. And moving it to v1.7 is better.

GiteaMirror commented

2025-11-02 04:27:58 -06:00

@stale[bot] commented on GitHub (Mar 5, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Mar 5, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

GiteaMirror commented

2025-11-02 04:27:59 -06:00

@rfwatson commented on GitHub (May 26, 2019):

Seems to be happening because this event listener is hijacking the click in split view. It isn't bound in unified view.

You can try removing the listener from the button using Chrome devtools in split view, the issue is immediately resolved.

@rfwatson commented on GitHub (May 26, 2019): Seems to be happening because [this event listener](https://github.com/rfwatson/gitea/blob/0c73755e039fbc62d000af79cf563ce29c136f41/public/js/index.js#L1050) is hijacking the click in split view. It isn't bound in unified view. You can try removing the listener from the button using Chrome devtools in split view, the issue is immediately resolved.

GiteaMirror commented

2025-11-02 04:27:59 -06:00

@lunny commented on GitHub (May 26, 2019):

@rfwatson could you send a PR to fix that?

@lunny commented on GitHub (May 26, 2019): @rfwatson could you send a PR to fix that?

GiteaMirror commented

2025-11-02 04:28:00 -06:00

@silverwind commented on GitHub (Jun 10, 2020):

https://github.com/go-gitea/gitea/pull/7052 was merged, this can be closed, right?

@silverwind commented on GitHub (Jun 10, 2020): https://github.com/go-gitea/gitea/pull/7052 was merged, this can be closed, right?

Sign in to join this conversation.