If the first word at WORK_IN_PROGRESS_PREFIXES starts with <, the hint is shown incorrectly #2197

New Issue

GiteaMirror · 2025-11-02T04:26:47-06:00

GiteaMirror commented

2025-11-02 04:26:47 -06:00

Originally created by @InExtremaRes on GitHub (Aug 14, 2018).

Gitea version (or commit ref): 03e558c
(the rest are not relevant or difficult)

Description

Since #4529 a commit can be marked as WIP. The WIP prefix can be configured. We have marked our PR with a <WIP> prefix format since a while, so we put that as the default. I have this in my app.ini:

[repository.pull-request]
; List of prefixes used in Pull Request title to mark them as Work In Progress
WORK_IN_PROGRESS_PREFIXES=<WIP>,WIP:,[WIP]

It works pretty well, except for the hint text that doesn't show the prefix to use:

You can see the hint only says Start the title with, without the <WIP>. For reference, here is how is showed with default values:

After a little of experimentation, it seems the problem occurs any time the prefix start with a < character.

@JulienTant

Originally created by @InExtremaRes on GitHub (Aug 14, 2018). - Gitea version (or commit ref): 03e558c (the rest are not relevant or difficult) ## Description Since #4529 a commit can be marked as _WIP_. The _WIP_ prefix can be configured. We have marked our PR with a `<WIP>` prefix format since a while, so we put that as the default. I have this in my app.ini: ```ini [repository.pull-request] ; List of prefixes used in Pull Request title to mark them as Work In Progress WORK_IN_PROGRESS_PREFIXES=<WIP>,WIP:,[WIP] ``` It works pretty well, except for the hint text that doesn't show the prefix to use: ![image](https://user-images.githubusercontent.com/1635491/44107865-0d4a7304-9fcf-11e8-9339-3f1c69296ff5.png) You can see the hint only says `Start the title with`, without the `<WIP>`. For reference, here is how is showed with default values: ![image](https://user-images.githubusercontent.com/1635491/44108005-732a1864-9fcf-11e8-9ec6-87b51a601d8d.png) After a little of experimentation, it seems the problem occurs any time the prefix start with a `<` character. @JulienTant

GiteaMirror added the type/bug label 2025-11-02 04:26:47 -06:00

GiteaMirror closed this issue

2025-11-02 04:26:47 -06:00

GiteaMirror commented

2025-11-02 04:26:48 -06:00

@JulienTant commented on GitHub (Aug 14, 2018):

Ok i'm going to take a look at this, this probably needs some html escaping before printing. Thanks for reporting

@JulienTant commented on GitHub (Aug 14, 2018): Ok i'm going to take a look at this, this probably needs some html escaping before printing. Thanks for reporting

GiteaMirror commented

2025-11-02 04:26:48 -06:00

@JulienTant commented on GitHub (Aug 15, 2018):

ICYMI @InExtremaRes I created a PR to fix the bug : #4709

@JulienTant commented on GitHub (Aug 15, 2018): ICYMI @InExtremaRes I created a PR to fix the bug : #4709

GiteaMirror commented

2025-11-02 04:26:49 -06:00

@InExtremaRes commented on GitHub (Aug 15, 2018):

Yes. Thank you so much. I'm following the discussion there.

@InExtremaRes commented on GitHub (Aug 15, 2018): Yes. Thank you so much. I'm following the discussion there.

GiteaMirror referenced this issue

2025-11-02 12:07:19 -06:00