Incorrect caption of webhook setting #2193

Closed
opened 2025-11-02 04:26:43 -06:00 by GiteaMirror · 0 comments
Owner

Originally created by @kzmi on GitHub (Aug 14, 2018).

  • Gitea version (or commit ref): master

Description

In "Add Webhook" page, a checkbox is captioned "Include Event Details", and its description is "Add information about the triggering event to requests."

But on the code, that option seems just a flag to make the webhook active or inactive.
I couldn't find the code that switches content of the webhook message, so I think that the caption is incorrect.

In old version of Gitea, the caption was "Active."
It was changed in commit bac6d05e78.
bac6d05e78 (diff-f65c5e89d3eccc273f66ad63e7852b64L991)

Screenshots

image

Originally created by @kzmi on GitHub (Aug 14, 2018). - Gitea version (or commit ref): master ## Description In "Add Webhook" page, a checkbox is captioned "Include Event Details", and its description is "Add information about the triggering event to requests." But on the code, that option seems just a flag to make the webhook active or inactive. I couldn't find the code that switches content of the webhook message, so I think that the caption is incorrect. In old version of Gitea, the caption was "Active." It was changed in commit bac6d05e78603ce9bb028f9ba2b77b9ea2975347. https://github.com/go-gitea/gitea/commit/bac6d05e78603ce9bb028f9ba2b77b9ea2975347#diff-f65c5e89d3eccc273f66ad63e7852b64L991 ## Screenshots ![image](https://user-images.githubusercontent.com/3753969/44094705-dfc25c88-a011-11e8-84d7-e2353e90c021.png)
GiteaMirror added the type/bugmodifies/translation labels 2025-11-02 04:26:43 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#2193