Issue dependencies ui kind of broken #2076

@jonasfranz commented on GitHub (Jul 20, 2018):

Ping @kolaente

@jonasfranz commented on GitHub (Jul 20, 2018): Ping @kolaente

GiteaMirror commented

@kolaente commented on GitHub (Jul 20, 2018):

This is something which should be fixed directly in the issue search, as I'm only using that (via the api). The results are the same as when you search on {projecturl}/issues.

I agree the issue search is not very good implemented.

@kolaente commented on GitHub (Jul 20, 2018): This is something which should be fixed directly in the issue search, as I'm only using that (via the api). The results are the same as when you search on `{projecturl}/issues`. I agree the issue search is not very good implemented.

GiteaMirror commented

@kolaente commented on GitHub (Jul 20, 2018):

I'd rather have the search return issues by their index instead of frankensteining this into the dependencies.

@kolaente commented on GitHub (Jul 20, 2018): I'd rather have the search return issues by their index instead of frankensteining this into the dependencies.

GiteaMirror commented

@stale[bot] commented on GitHub (Jan 17, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Jan 17, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

GiteaMirror commented

@stevegt commented on GitHub (Mar 5, 2019):

Just noticed that direct mention of the issue id is still not working as of 7d973edf65.

@stevegt commented on GitHub (Mar 5, 2019): Just noticed that direct mention of the issue id is still not working as of 7d973edf65c664ea4bdb0efe455f03c486727fa2.

GiteaMirror commented

@zeripath commented on GitHub (Mar 6, 2019):

@stevegt could you give a quick example of what you mean. Preferably with a try.gitea.io link?

It might be best to open another issue since this one is closed.

@zeripath commented on GitHub (Mar 6, 2019): @stevegt could you give a quick example of what you mean. Preferably with a try.gitea.io link? It might be best to open another issue since this one is closed.

GiteaMirror commented

@stevegt commented on GitHub (Mar 6, 2019):

@zeripath A 'try' link won't help -- go to any issue you can edit and enter an issue number into the 'dependencies' field, either with or without a leading '#'. You'll see that you get an error response of 'Dependent issue does not exist.'

This issue was recently closed by stale bot due to lack of activity, not because it's been addressed. There has been no merge referencing it. Re-opening would be the normal thing to do, rather than fragment the conversation. I'll let it sit for a while to see if anyone with access re-opens. I may get to this with a fix myself at some point as well.

@stevegt commented on GitHub (Mar 6, 2019): @zeripath A 'try' link won't help -- go to any issue you can edit and enter an issue number into the 'dependencies' field, either with or without a leading '#'. You'll see that you get an error response of 'Dependent issue does not exist.' This issue was recently closed by stale bot due to lack of activity, not because it's been addressed. There has been no merge referencing it. Re-opening would be the normal thing to do, rather than fragment the conversation. I'll let it sit for a while to see if anyone with access re-opens. I may get to this with a fix myself at some point as well.

GiteaMirror commented

@nascimentolwtn commented on GitHub (Mar 26, 2019):

For me is happening something similar, but it seems to be a cache problem, because if I create a sequence of issues, only old ones once shown are listed on new issues to be included as dependency. Also, it seems to show only the first page of opened issues (typing '#' would help).

A workaround: change browser or clear cache history.

@nascimentolwtn commented on GitHub (Mar 26, 2019): For me is happening something similar, but it seems to be a cache problem, because if I create a sequence of issues, only old ones once shown are listed on new issues to be included as dependency. Also, it seems to show only the first page of opened issues (typing '#' would help). A workaround: change browser or clear cache history.

GiteaMirror commented

@xf- commented on GitHub (May 11, 2019):

@nascimentolwtn i think is is caused by service worker and caching the result

@xf- commented on GitHub (May 11, 2019): @nascimentolwtn i think is is caused by service worker and caching the result

GiteaMirror commented

@lesh59 commented on GitHub (Dec 4, 2020):

I think the dependency drop down is only showing the first page of issues. Changing the ISSUE_PAGING_NUM in app.ini to a larger number showed more issues in the drop down (and on the issues page of course). The drop down should not be affected by "pages", should be all issues, filtered as you type.

@lesh59 commented on GitHub (Dec 4, 2020): I think the dependency drop down is only showing the first page of issues. Changing the **ISSUE_PAGING_NUM** in app.ini to a larger number showed more issues in the drop down (and on the issues page of course). The drop down should not be affected by "pages", should be all issues, filtered as you type.

GiteaMirror commented

@samaust commented on GitHub (Mar 8, 2021):

Tested on version 1.11.6 :

Searching the title of an issue that is not in the choices shown in the drop-down menu works.
Searching the linked reference (mike/compiler#1234) does not return results.

@samaust commented on GitHub (Mar 8, 2021): Tested on version 1.11.6 : * Searching the title of an issue that is not in the choices shown in the drop-down menu works. * Searching the linked reference (mike/compiler#1234) does not return results.

GiteaMirror commented

@6543 commented on GitHub (Mar 8, 2021):

@samaust sorry, we dont support anymore v1.11.6 & you should upgrade for security reasons

@6543 commented on GitHub (Mar 8, 2021): @samaust sorry, we dont support anymore v1.11.6 & you should upgrade for security reasons

GiteaMirror commented

@stevegt commented on GitHub (Mar 18, 2021):

@6543 The fact that @samaust is running an old version is orthogonal to this issue -- the bug still exists in 1.14.0+dev-874-ge8ad6c1ff.

@stevegt commented on GitHub (Mar 18, 2021): @6543 The fact that @samaust is running an old version is orthogonal to this issue -- the bug still exists in 1.14.0+dev-874-ge8ad6c1ff.

GiteaMirror commented

@Giszmo commented on GitHub (Apr 14, 2022):

I installed from snap yesterday and ran into this same issue.

gitea 1.16.5

Not sure if bugbounties are welcome but I'd tip $50 in BTC for this to be fixed.

@Giszmo commented on GitHub (Apr 14, 2022): I installed from snap yesterday and ran into this same issue. gitea 1.16.5 Not sure if bugbounties are welcome but I'd tip $50 in BTC for this to be fixed.

GiteaMirror commented

73382d2132/templates/repo/issue/view_content/sidebar.tmpl (L517-L534)

@Ryuno-Ki commented on GitHub (Jun 5, 2022):

The relevant template is

The associated JavaScript

73382d2132/web_src/js/features/repo-issue.js (L89-L123)

A few questions come to my mind:

Why is the JavaScript using .data() here? (see https://docs.gitea.io/en-us/guidelines-frontend/#html-attributes-and-dataset )
I can see AJAX requests like /issues/search?q=some&priority_repo_id=2&type=all&_=1654452403354 Where is the associated router? (formerly using /api/v1/repos/issues/search. Changed in 783a021889 (diff-d39a63ccfd5f0fe703f74ce48a3624ba59a856317b0d236d7eae87dfcf6c1c20) ) The one below?
Searching for something in the title or body (whole words) work. We want to reference the issue ID here, though.

7b089c465d/routers/web/repo/search.go (L19-L58)

@Ryuno-Ki commented on GitHub (Jun 5, 2022): The relevant template is https://github.com/go-gitea/gitea/blob/73382d2132f8f242245d83f66c92761e0b477b91/templates/repo/issue/view_content/sidebar.tmpl#L517-L534 The associated JavaScript https://github.com/go-gitea/gitea/blob/73382d2132f8f242245d83f66c92761e0b477b91/web_src/js/features/repo-issue.js#L89-L123 A few questions come to my mind: 1. Why is the JavaScript using `.data()` here? (see https://docs.gitea.io/en-us/guidelines-frontend/#html-attributes-and-dataset ) 2. I can see AJAX requests like `/issues/search?q=some&priority_repo_id=2&type=all&_=1654452403354` Where is the associated router? (formerly using `/api/v1/repos/issues/search`. Changed in https://github.com/go-gitea/gitea/commit/783a02188970ba5800514f7c64f6a818f65c04a1#diff-d39a63ccfd5f0fe703f74ce48a3624ba59a856317b0d236d7eae87dfcf6c1c20 ) The one below? 3. Searching for something in the title or body (whole words) work. We want to reference the issue ID here, though. https://github.com/go-gitea/gitea/blob/7b089c465d9f851454be91ca209ab26782648a45/routers/web/repo/search.go#L19-L58

GiteaMirror commented

d9b50e4fd1/routers/web/web.go (L320)

@Ryuno-Ki commented on GitHub (Jun 5, 2022):

I got an explanation on routers in the chat.

The router in

passes the request to SearchIssues:

744e452185/routers/web/repo/issue.go (L2144-L2317)

That makes

744e452185/modules/indexer/issues/indexer.go (L385-L401)

the code that searches the issues.

Therefore, this issue is likely not of kind/ui.

@Ryuno-Ki commented on GitHub (Jun 5, 2022): I got an explanation on routers in the chat. The router in https://github.com/go-gitea/gitea/blob/d9b50e4fd126e60fe0735bafbcb12d0e8f6dd0c2/routers/web/web.go#L320 passes the request to `SearchIssues`: https://github.com/go-gitea/gitea/blob/744e45218579fe2fd130b91d9fb95ec4becd314d/routers/web/repo/issue.go#L2144-L2317 That makes https://github.com/go-gitea/gitea/blob/744e45218579fe2fd130b91d9fb95ec4becd314d/modules/indexer/issues/indexer.go#L385-L401 the code that searches the issues. Therefore, this issue is likely not of `kind/ui`.

GiteaMirror commented