Clicking on the Code-tab leads to invalid URL #1943

Closed
opened 2025-11-02 04:18:38 -06:00 by GiteaMirror · 7 comments
Owner

Originally created by @cleverer on GitHub (Jun 16, 2018).

Description

When browsing a tag, clicking on the Code-tab leads to an invalid url/404. It incorrectly gets linked to src/branch/tagname instead of src/tag/tagname.

Screenshots

ezgif-1-d7c9ebecac

Originally created by @cleverer on GitHub (Jun 16, 2018). - Gitea version (or commit ref): 1.4.2 - Git version: 2.17.0 - Operating system: macOS 10.13.4 - Database (use `[x]`): - [ ] PostgreSQL - [x] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [x] No, but on https://git.damutten.ch/Nicolas/todolist - [ ] Not relevant - Log gist: ## Description When browsing a tag, clicking on the Code-tab leads to an invalid url/404. It incorrectly gets linked to src/**branch**/_tagname_ instead of src/**tag**/_tagname_. ## Screenshots ![ezgif-1-d7c9ebecac](https://user-images.githubusercontent.com/1735317/41500340-ba94b1f0-718f-11e8-8113-85ed205dbb8b.gif)
GiteaMirror added the type/bug label 2025-11-02 04:18:38 -06:00
Author
Owner

@johnrazeur commented on GitHub (Jun 16, 2018):

Hello,
it's a regression caused by #3776.
I can try to fix this if a maintainer allows me !

@johnrazeur commented on GitHub (Jun 16, 2018): Hello, it's a regression caused by #3776. I can try to fix this if a maintainer allows me !
Author
Owner

@daviian commented on GitHub (Jun 16, 2018):

As far as I see this issue only occurs on the release/1.4 branch and not on master. Is this correct?

@johnrazeur of course, we are happy if you do!

@daviian commented on GitHub (Jun 16, 2018): As far as I see this issue only occurs on the release/1.4 branch and not on master. Is this correct? @johnrazeur of course, we are happy if you do!
Author
Owner

@johnrazeur commented on GitHub (Jun 16, 2018):

Yes, the issue doesn't occurs on master.

@johnrazeur commented on GitHub (Jun 16, 2018): Yes, the issue doesn't occurs on master.
Author
Owner

@cleverer commented on GitHub (Jun 16, 2018):

@daviian It seems like it, yes. Just wanted to comment on it, but you were a few seconds faster…
I reinstalled it with brew reinstall --devel and it works like a charm now.

@johnrazeur Thanks for offering to help!

I'm closing the issue for now.

@cleverer commented on GitHub (Jun 16, 2018): @daviian It seems like it, yes. Just wanted to comment on it, but you were a few seconds faster… I reinstalled it with `brew reinstall --devel` and it works like a charm now. @johnrazeur Thanks for offering to help! I'm closing the issue for now.
Author
Owner

@lunny commented on GitHub (Jun 17, 2018):

@cleverer I would like stay this on v1.4.3 @johnrazeur please send a PR to release/v1.4

@lunny commented on GitHub (Jun 17, 2018): @cleverer I would like stay this on v1.4.3 @johnrazeur please send a PR to release/v1.4
Author
Owner

@cleverer commented on GitHub (Jun 17, 2018):

Found the commit, which fixes the behaviour: 3a6f3c8c11, #3908

@cleverer commented on GitHub (Jun 17, 2018): Found the commit, which fixes the behaviour: 3a6f3c8c119927b4ed9ea814342f1b15bd29d93d, #3908
Author
Owner

@daviian commented on GitHub (Jun 17, 2018):

Fixed by #4263

@daviian commented on GitHub (Jun 17, 2018): Fixed by #4263
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#1943