github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-09 12:46:42 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

File permissions not being updated/checked on rewrite #1925

New Issue
Closed
opened 2025-11-02 04:18:00 -06:00 by GiteaMirror · 2 comments
GiteaMirror commented 2025-11-02 04:18:00 -06:00
Owner
Copy Link

Originally created by @tobias-- on GitHub (Jun 12, 2018).

  • Gitea version (or commit ref): 1.4.2
  • Git version:
  • Operating system: Linux ecm07 4.4.0-127-generic #153-Ubuntu SMP Sat May 19 10:58:46 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

I noticed that the git hooks stopped working (after migrating to another server). Rewriting the hooks from the administration panel did not yield any results. Newly created repositories work fine, but the pre-migration ones do not. I noticed that the file permissions of the hooks directory differ:

ls -lah old-repo.git/hooks/
total 76K
drwxrwxr-x 5 gitea gitea 4,0K Jun 12 09:32 ./
drwxrwxr-x 7 gitea gitea 4,0K Mai 29 14:43 ../
-rw-rw-r-- 1 gitea gitea  478 Jun 25  2017 applypatch-msg.sample
-rw-rw-r-- 1 gitea gitea  896 Jun 25  2017 commit-msg.sample
-rw-rw-r-- 1 gitea gitea  303 Jun 12 09:29 post-receive
drwxrwxr-x 2 gitea gitea 4,0K Jun 12 09:32 post-receive.d/
-rw-rw-r-- 1 gitea gitea  189 Jun 25  2017 post-update.sample
-rw-rw-r-- 1 gitea gitea  424 Jun 25  2017 pre-applypatch.sample
-rw-rw-r-- 1 gitea gitea 1,7K Jun 25  2017 pre-commit.sample
-rw-rw-r-- 1 gitea gitea 1,3K Jun 25  2017 prepare-commit-msg.sample
-rw-rw-r-- 1 gitea gitea 1,4K Jun 25  2017 pre-push.sample
-rw-rw-r-- 1 gitea gitea 4,9K Jun 25  2017 pre-rebase.sample
-rw-rw-r-- 1 gitea gitea  303 Jun 12 09:29 pre-receive
drwxrwxr-x 2 gitea gitea 4,0K Jun 25  2017 pre-receive.d/
-rw-rw-r-- 1 gitea gitea  544 Jun 25  2017 pre-receive.sample
-rw-rw-r-- 1 gitea gitea  283 Jun 12 09:29 update
drwxrwxr-x 2 gitea gitea 4,0K Jun 25  2017 update.d/
-rw-rw-r-- 1 gitea gitea 3,6K Jun 25  2017 update.sample

ls -lah new-repo.git/hooks/
total 72K
drwxr-xr-x 5 gitea gitea 4,0K Jun 12 09:36 ./
drwxr-xr-x 7 gitea gitea 4,0K Jun 12 09:36 ../
-rwxr-xr-x 1 gitea gitea  478 Jun 12 09:36 applypatch-msg.sample*
-rwxr-xr-x 1 gitea gitea  896 Jun 12 09:36 commit-msg.sample*
-rwxr-xr-x 1 gitea gitea  303 Jun 12 09:36 post-receive*
drwxr-xr-x 2 gitea gitea 4,0K Jun 12 09:36 post-receive.d/
-rwxr-xr-x 1 gitea gitea  189 Jun 12 09:36 post-update.sample*
-rwxr-xr-x 1 gitea gitea  424 Jun 12 09:36 pre-applypatch.sample*
-rwxr-xr-x 1 gitea gitea 1,7K Jun 12 09:36 pre-commit.sample*
-rwxr-xr-x 1 gitea gitea 1,3K Jun 12 09:36 prepare-commit-msg.sample*
-rwxr-xr-x 1 gitea gitea 1,4K Jun 12 09:36 pre-push.sample*
-rwxr-xr-x 1 gitea gitea 4,8K Jun 12 09:36 pre-rebase.sample*
-rwxr-xr-x 1 gitea gitea  303 Jun 12 09:36 pre-receive*
drwxr-xr-x 2 gitea gitea 4,0K Jun 12 09:36 pre-receive.d/
-rwxr-xr-x 1 gitea gitea  283 Jun 12 09:36 update*
drwxr-xr-x 2 gitea gitea 4,0K Jun 12 09:36 update.d/
-rwxr-xr-x 1 gitea gitea 3,6K Jun 12 09:36 update.sample*

Deleting old-repo.git/hooks and rewriting hooks from the admin panel fixes the problem and recreates the hooks dir with the same permissions as newly created repositories (but the sample files do not get recreated).

ls -lah new-repo.git/hooks/
total 32K
drwxr-xr-x 5 gitea gitea 4,0K Jun 12 09:48 ./
drwxrwxr-x 8 gitea gitea 4,0K Jun 12 09:48 ../
-rwxr-xr-x 1 gitea gitea  303 Jun 12 09:48 post-receive*
drwxr-xr-x 2 gitea gitea 4,0K Jun 12 09:48 post-receive.d/
-rwxr-xr-x 1 gitea gitea  303 Jun 12 09:48 pre-receive*
drwxr-xr-x 2 gitea gitea 4,0K Jun 12 09:48 pre-receive.d/
-rwxr-xr-x 1 gitea gitea  283 Jun 12 09:48 update*
drwxr-xr-x 2 gitea gitea 4,0K Jun 12 09:48 update.d/
Originally created by @tobias-- on GitHub (Jun 12, 2018). - Gitea version (or commit ref): 1.4.2 - Git version: - Operating system: Linux ecm07 4.4.0-127-generic #153-Ubuntu SMP Sat May 19 10:58:46 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux - Database (use `[x]`): - [ ] PostgreSQL - [ ] MySQL - [ ] MSSQL - [x] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [x] Not relevant - Log gist: ## Description I noticed that the git hooks stopped working (after migrating to another server). Rewriting the hooks from the administration panel did not yield any results. Newly created repositories work fine, but the pre-migration ones do not. I noticed that the file permissions of the hooks directory differ: ``` ls -lah old-repo.git/hooks/ total 76K drwxrwxr-x 5 gitea gitea 4,0K Jun 12 09:32 ./ drwxrwxr-x 7 gitea gitea 4,0K Mai 29 14:43 ../ -rw-rw-r-- 1 gitea gitea 478 Jun 25 2017 applypatch-msg.sample -rw-rw-r-- 1 gitea gitea 896 Jun 25 2017 commit-msg.sample -rw-rw-r-- 1 gitea gitea 303 Jun 12 09:29 post-receive drwxrwxr-x 2 gitea gitea 4,0K Jun 12 09:32 post-receive.d/ -rw-rw-r-- 1 gitea gitea 189 Jun 25 2017 post-update.sample -rw-rw-r-- 1 gitea gitea 424 Jun 25 2017 pre-applypatch.sample -rw-rw-r-- 1 gitea gitea 1,7K Jun 25 2017 pre-commit.sample -rw-rw-r-- 1 gitea gitea 1,3K Jun 25 2017 prepare-commit-msg.sample -rw-rw-r-- 1 gitea gitea 1,4K Jun 25 2017 pre-push.sample -rw-rw-r-- 1 gitea gitea 4,9K Jun 25 2017 pre-rebase.sample -rw-rw-r-- 1 gitea gitea 303 Jun 12 09:29 pre-receive drwxrwxr-x 2 gitea gitea 4,0K Jun 25 2017 pre-receive.d/ -rw-rw-r-- 1 gitea gitea 544 Jun 25 2017 pre-receive.sample -rw-rw-r-- 1 gitea gitea 283 Jun 12 09:29 update drwxrwxr-x 2 gitea gitea 4,0K Jun 25 2017 update.d/ -rw-rw-r-- 1 gitea gitea 3,6K Jun 25 2017 update.sample ``` ``` ls -lah new-repo.git/hooks/ total 72K drwxr-xr-x 5 gitea gitea 4,0K Jun 12 09:36 ./ drwxr-xr-x 7 gitea gitea 4,0K Jun 12 09:36 ../ -rwxr-xr-x 1 gitea gitea 478 Jun 12 09:36 applypatch-msg.sample* -rwxr-xr-x 1 gitea gitea 896 Jun 12 09:36 commit-msg.sample* -rwxr-xr-x 1 gitea gitea 303 Jun 12 09:36 post-receive* drwxr-xr-x 2 gitea gitea 4,0K Jun 12 09:36 post-receive.d/ -rwxr-xr-x 1 gitea gitea 189 Jun 12 09:36 post-update.sample* -rwxr-xr-x 1 gitea gitea 424 Jun 12 09:36 pre-applypatch.sample* -rwxr-xr-x 1 gitea gitea 1,7K Jun 12 09:36 pre-commit.sample* -rwxr-xr-x 1 gitea gitea 1,3K Jun 12 09:36 prepare-commit-msg.sample* -rwxr-xr-x 1 gitea gitea 1,4K Jun 12 09:36 pre-push.sample* -rwxr-xr-x 1 gitea gitea 4,8K Jun 12 09:36 pre-rebase.sample* -rwxr-xr-x 1 gitea gitea 303 Jun 12 09:36 pre-receive* drwxr-xr-x 2 gitea gitea 4,0K Jun 12 09:36 pre-receive.d/ -rwxr-xr-x 1 gitea gitea 283 Jun 12 09:36 update* drwxr-xr-x 2 gitea gitea 4,0K Jun 12 09:36 update.d/ -rwxr-xr-x 1 gitea gitea 3,6K Jun 12 09:36 update.sample* ``` Deleting old-repo.git/hooks and rewriting hooks from the admin panel fixes the problem and recreates the hooks dir with the same permissions as newly created repositories (but the sample files do not get recreated). ``` ls -lah new-repo.git/hooks/ total 32K drwxr-xr-x 5 gitea gitea 4,0K Jun 12 09:48 ./ drwxrwxr-x 8 gitea gitea 4,0K Jun 12 09:48 ../ -rwxr-xr-x 1 gitea gitea 303 Jun 12 09:48 post-receive* drwxr-xr-x 2 gitea gitea 4,0K Jun 12 09:48 post-receive.d/ -rwxr-xr-x 1 gitea gitea 303 Jun 12 09:48 pre-receive* drwxr-xr-x 2 gitea gitea 4,0K Jun 12 09:48 pre-receive.d/ -rwxr-xr-x 1 gitea gitea 283 Jun 12 09:48 update* drwxr-xr-x 2 gitea gitea 4,0K Jun 12 09:48 update.d/ ````
GiteaMirror added the issue/staletype/bug labels 2025-11-02 04:18:00 -06:00
GiteaMirror commented 2025-11-02 04:18:02 -06:00
Author
Owner
Copy Link

@stale[bot] commented on GitHub (Jan 24, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Jan 24, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.
GiteaMirror commented 2025-11-02 04:18:02 -06:00
Author
Owner
Copy Link

@stale[bot] commented on GitHub (Feb 18, 2019):

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale[bot] commented on GitHub (Feb 18, 2019): This issue has been automatically closed because of inactivity. You can re-open it if needed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/stale type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#1925
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?