Can not suport git revision version contains '-' #1896

New Issue

GiteaMirror · 2025-11-02T04:17:07-06:00

GiteaMirror commented

2025-11-02 04:17:07 -06:00

Originally created by @duffiye on GitHub (Jun 8, 2018).

Gitea version (or commit ref): v1.4
Git version: 2.18.0-rc1
Operating system: centos 6
Database (use [x]):
- PostgreSQL
- MySQL
- MSSQL
- SQLite
Can you reproduce the bug at https://try.gitea.io:
- Yes (provide example URL)
- No
- Not relevant

Log gist:

   2018/06/08 03:57:01 [...s/setting/setting.go:890 NewContext()] [E] Error parsing git revision version: strconv.ParseUint: parsing "0-rc1": invalid syntax

Description

Can not suport git revision version contains '-' ;

 	revisionVersion, err := strconv.ParseUint(splitVersion[2], 10, 64)
	if err != nil {
		log.Fatal(4, "Error parsing git revision version: %v", err)
	}

maybe can do it like this:

     revisionVersion, err := strconv.ParseUint(strings.SplitN(splitVersion[2], "-", 1), 10, 64)

Screenshots

Originally created by @duffiye on GitHub (Jun 8, 2018).  - Gitea version (or commit ref): v1.4 - Git version: 2.18.0-rc1 - Operating system: centos 6 - Database (use `[x]`): - [ ] PostgreSQL - [x] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [x] No - [ ] Not relevant - Log gist: 2018/06/08 03:57:01 [...s/setting/setting.go:890 NewContext()] [E] Error parsing git revision version: strconv.ParseUint: parsing "0-rc1": invalid syntax ## Description Can not suport git revision version contains '-' ; revisionVersion, err := strconv.ParseUint(splitVersion[2], 10, 64) if err != nil { log.Fatal(4, "Error parsing git revision version: %v", err) } maybe can do it like this: revisionVersion, err := strconv.ParseUint(strings.SplitN(splitVersion[2], "-", 1), 10, 64) ## Screenshots

GiteaMirror added the issue/confirmed type/bug labels 2025-11-02 04:17:07 -06:00

GiteaMirror closed this issue

2025-11-02 04:17:07 -06:00

GiteaMirror commented

2025-11-02 04:17:08 -06:00

@duffiye commented on GitHub (Jun 8, 2018):

            rv := strings.SplitN(splitVersion[2], "-", 2)
            log.Info(rv[0])
            revisionVersion, err := strconv.ParseUint(rv[0], 10, 64)

@duffiye commented on GitHub (Jun 8, 2018): rv := strings.SplitN(splitVersion[2], "-", 2) log.Info(rv[0]) revisionVersion, err := strconv.ParseUint(rv[0], 10, 64)

GiteaMirror commented

2025-11-02 04:17:08 -06:00

@stale[bot] commented on GitHub (Jan 24, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Jan 24, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

GiteaMirror commented

2025-11-02 04:17:09 -06:00

@stale[bot] commented on GitHub (Feb 18, 2019):

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale[bot] commented on GitHub (Feb 18, 2019): This issue has been automatically closed because of inactivity. You can re-open it if needed.

GiteaMirror commented

2025-11-02 04:17:09 -06:00

@6543 commented on GitHub (Sep 17, 2020):

should be the case now, feel free to ask for reopen if you have still issues with it

@6543 commented on GitHub (Sep 17, 2020): should be the case now, feel free to ask for reopen if you have still issues with it

GiteaMirror referenced this issue

2025-11-02 12:02:28 -06:00