Can not edit issue description after creation #1888

@lafriks commented on GitHub (Jun 8, 2018):

@shortmotiv yes

@lafriks commented on GitHub (Jun 8, 2018): @shortmotiv yes

GiteaMirror commented

@exploide commented on GitHub (Jul 19, 2018):

Can confirm the bug is present on latest stable 1.4.3.

However, we figured out that this depends on your permission level. Admins can edit their issue comments while regular users are affected by this bug.

@exploide commented on GitHub (Jul 19, 2018): Can confirm the bug is present on latest stable 1.4.3. However, we figured out that this depends on your permission level. Admins can edit their issue comments while regular users are affected by this bug.

GiteaMirror commented

@fazlerabbi37 commented on GitHub (Jul 19, 2018):

@exploide in my case all of the users were admin.

@fazlerabbi37 commented on GitHub (Jul 19, 2018): @exploide in my case all of the users were admin.

GiteaMirror commented

@ghost commented on GitHub (Aug 2, 2018):

Can confirm the bug is present on latest stable 1.4.3.

This issue should be tagged as bug.

Edit: Or regression since it used to work in past versions.

@ghost commented on GitHub (Aug 2, 2018): > Can confirm the bug is present on latest stable 1.4.3. This issue should be tagged as `bug`. **Edit:** Or `regression` since it used to work in past versions.

GiteaMirror commented

@exploide commented on GitHub (Aug 7, 2018):

Ok, I looked a bit further:

it's possible to edit the comment via the API, the problem only occurs when using the web ui
I'm only affected when I'm not added as a collaborator

@exploide commented on GitHub (Aug 7, 2018): Ok, I looked a bit further: - it's possible to edit the comment via the API, the problem only occurs when using the web ui - I'm only affected when I'm not added as a collaborator

GiteaMirror commented

https://try.gitea.io/kaeptmblaubaer1000/cpython/issues/9#

@coolaj86 commented on GitHub (Aug 28, 2018):

Reproducible on https://try.gitea.io (Gitea Version: 179123d)

Uncaught ReferenceError: issuesTribute is not defined
    at HTMLAnchorElement.<anonymous> (index.js?v=1defe2eb62a33a98f1643bfb09d4ede7:608)
    at HTMLAnchorElement.dispatch (jquery.min.js:3)
    at HTMLAnchorElement.r.handle (jquery.min.js:3)

@coolaj86 commented on GitHub (Aug 28, 2018): Reproducible on https://try.gitea.io (Gitea Version: 179123d) https://try.gitea.io/kaeptmblaubaer1000/cpython/issues/9# ``` Uncaught ReferenceError: issuesTribute is not defined at HTMLAnchorElement.<anonymous> (index.js?v=1defe2eb62a33a98f1643bfb09d4ede7:608) at HTMLAnchorElement.dispatch (jquery.min.js:3) at HTMLAnchorElement.r.handle (jquery.min.js:3) ``` ![screen shot 2018-08-28 at 5 22 08 pm](https://user-images.githubusercontent.com/122831/44756268-1584eb80-aae7-11e8-90c8-9673effdad58.png)

GiteaMirror commented

@coolaj86 commented on GitHub (Aug 28, 2018):

It appears that the error occurs when hitting the edit button.

In the released v1.5.0 I get a different error:

index.js?v=35c36e89ef751b74c7aa3b07d7e0f6b6:609

Uncaught ReferenceError: emojiTribute is not defined
    at HTMLAnchorElement.<anonymous> (index.js?v=35c36e89ef751b74c7aa3b07d7e0f6b6:609)
    at HTMLAnchorElement.dispatch (jquery.min.js:4)
    at HTMLAnchorElement.r.handle (jquery.min.js:4)

@coolaj86 commented on GitHub (Aug 28, 2018): It appears that the error occurs when hitting the edit button. In the released v1.5.0 I get a different error: ``` index.js?v=35c36e89ef751b74c7aa3b07d7e0f6b6:609 Uncaught ReferenceError: emojiTribute is not defined at HTMLAnchorElement.<anonymous> (index.js?v=35c36e89ef751b74c7aa3b07d7e0f6b6:609) at HTMLAnchorElement.dispatch (jquery.min.js:4) at HTMLAnchorElement.r.handle (jquery.min.js:4) ``` ![screen shot 2018-08-28 at 5 26 54 pm](https://user-images.githubusercontent.com/122831/44756377-96dc7e00-aae7-11e8-8388-5a880561858f.png)

GiteaMirror commented

@coolaj86 commented on GitHub (Aug 28, 2018):

This is NOT a bug in v1.4.2

@coolaj86 commented on GitHub (Aug 28, 2018): This is NOT a bug in v1.4.2

GiteaMirror commented

@coolaj86 commented on GitHub (Aug 29, 2018):

Probable Problem / Solution

Dear people who are having issues with this:

tree gitea/custom/templates

(or find gitea/custom/templates if you don't have tree installed)

I think the culprit (which makes sense for https://try.gitea.io as well) is the use of custom templates.

You update a version of gitea and you'd think that all the things you aren't modifying would be fine. Certainly there shouldn't be javascript errors when you've only edited html templates... wrong!

The templates are very dirty - they mix and match script tag and full scripts rather than isolating the JavaScript from the template and consolidating it into a single file.

Classic front-end development probs.

@coolaj86 commented on GitHub (Aug 29, 2018): Probable Problem / Solution ===== Dear people who are having issues with this: ```bash tree gitea/custom/templates ``` (or `find gitea/custom/templates` if you don't have `tree` installed) I think the culprit (which makes sense for https://try.gitea.io as well) is the use of **custom templates**. You update a version of gitea and you'd think that all the things you aren't modifying would be fine. Certainly there shouldn't be javascript errors when you've only edited html templates... wrong! The templates are very dirty - they mix and match script tag and full scripts rather than isolating the JavaScript from the template and consolidating it into a single file. Classic front-end development probs.

GiteaMirror commented

@neuoy commented on GitHub (Dec 3, 2018):

I have the "issuesTribute is not defined" error as well, when editing a comment on an issue, on gitea 1.6.0. I haven't customized anything. I don't think I even have a "custom" folder. I also had the same behavior on v1.4.2, though I haven't checked the javascript console output on that version.

@neuoy commented on GitHub (Dec 3, 2018): I have the "issuesTribute is not defined" error as well, when editing a comment on an issue, on gitea 1.6.0. I haven't customized anything. I don't think I even have a "custom" folder. I also had the same behavior on v1.4.2, though I haven't checked the javascript console output on that version.

GiteaMirror commented

@gfwing commented on GitHub (Dec 5, 2018):

Can you reproduce the bug at https://try.gitea.io: Gitea Version: fdec258
- Yes (https://try.gitea.io/gfPlay/orgRepo/issues/2#issuecomment-8810)
- No
- Not relevant

Description

same as @neuoy , and I test it for collaborator with admin, write, and read permission

the admin and write permission are fine.
the issue happened when read permission.

the collaborator can delete the comment but cannot edit the text.
this situation doesn't make sense.

@gfwing commented on GitHub (Dec 5, 2018): - Can you reproduce the bug at https://try.gitea.io: Gitea Version: fdec258 - [x] Yes (https://try.gitea.io/gfPlay/orgRepo/issues/2#issuecomment-8810) - [ ] No - [ ] Not relevant ## Description same as @neuoy , and I test it for collaborator with admin, write, and read permission the admin and write permission are fine. the issue happened when read permission. the collaborator can delete the comment but cannot edit the text. this situation doesn't make sense.

GiteaMirror commented

@lunny commented on GitHub (Dec 11, 2018):

I can confirm this is a bug, when a read permission user create an issue, then edit the issue will reproduce it.

@lunny commented on GitHub (Dec 11, 2018): I can confirm this is a bug, when a read permission user create an issue, then edit the issue will reproduce it.

GiteaMirror commented

@lunny commented on GitHub (Dec 11, 2018):

@shortmotiv @coolaj86 @neuoy @gfwing please confirm #5516 fix your problem.

@lunny commented on GitHub (Dec 11, 2018): @shortmotiv @coolaj86 @neuoy @gfwing please confirm #5516 fix your problem.

GiteaMirror commented