github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-13 02:57:44 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #5634] [MERGED] SECURITY: prevent DeleteFilePost doing arbitrary deletion #17878

New Issue
Closed
opened 2025-11-02 16:24:33 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 16:24:33 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/5634
Author: @zeripath
Created: 1/4/2019
Status: ✅ Merged
Merged: 1/4/2019
Merged by: @jonasfranz

Base: release/v1.6 ← Head: protect-delete-file

📝 Commits (1)

  • 4108d3c SECURITY: protect DeleteFilePost et al with cleanUploadFileName (#5631)

📊 Changes

1 file changed (+18 additions, -2 deletions)

View changed files

📝 routers/repo/editor.go (+18 -2)

📄 Description

Unfortunately a suitably malformed request to DeleteFilePost will allow arbitrary deletion. Further it was also possible to adjust the .git directories on editFilePost and UploadFilePost.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/5634 **Author:** [@zeripath](https://github.com/zeripath) **Created:** 1/4/2019 **Status:** ✅ Merged **Merged:** 1/4/2019 **Merged by:** [@jonasfranz](https://github.com/jonasfranz) **Base:** `release/v1.6` ← **Head:** `protect-delete-file` --- ### 📝 Commits (1) - [`4108d3c`](https://github.com/go-gitea/gitea/commit/4108d3c2da6245ff7264a588c4fd4093ff4b9894) SECURITY: protect DeleteFilePost et al with cleanUploadFileName (#5631) ### 📊 Changes **1 file changed** (+18 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `routers/repo/editor.go` (+18 -2) </details> ### 📄 Description Unfortunately a suitably malformed request to DeleteFilePost will allow arbitrary deletion. Further it was also possible to adjust the .git directories on editFilePost and UploadFilePost. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 16:24:33 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#17878
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?