github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-13 19:37:47 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #5622] [MERGED] Don't close issues via commits on non-default branch. #17874

New Issue
Closed
opened 2025-11-02 16:22:48 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 16:22:48 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/5622
Author: @HarshitOnGitHub
Created: 1/2/2019
Status: ✅ Merged
Merged: 1/4/2019
Merged by: @lafriks

Base: master ← Head: Issue_2314

📝 Commits (2)

  • 1d65f8c issue: Don't close issues via commits on non-default branch.
  • 8660b18 refactor: Extract changeIssueStatus() function.

📊 Changes

2 files changed (+63 additions, -40 deletions)

View changed files

📝 models/action.go (+35 -39)
📝 models/action_test.go (+28 -1)

📄 Description

This PR includes a bug fix as well as a small refactor.

Fixes: #2314.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/5622 **Author:** [@HarshitOnGitHub](https://github.com/HarshitOnGitHub) **Created:** 1/2/2019 **Status:** ✅ Merged **Merged:** 1/4/2019 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `master` ← **Head:** `Issue_2314` --- ### 📝 Commits (2) - [`1d65f8c`](https://github.com/go-gitea/gitea/commit/1d65f8cad52b0d5d63aeb9051336c3b3b3d6b536) issue: Don't close issues via commits on non-default branch. - [`8660b18`](https://github.com/go-gitea/gitea/commit/8660b18901b0a2e23b4f158ffc0879f6868e60e9) refactor: Extract `changeIssueStatus()` function. ### 📊 Changes **2 files changed** (+63 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `models/action.go` (+35 -39) 📝 `models/action_test.go` (+28 -1) </details> ### 📄 Description This PR includes a bug fix as well as a small refactor. Fixes: #2314. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 16:22:48 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#17874
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?