[PR #5575] [MERGED] Backport #5570 - Immediate fix to htmlEncode user added text #17852

Closed
opened 2025-11-02 16:16:03 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/5575
Author: @techknowlogick
Created: 12/21/2018
Status: Merged
Merged: 12/21/2018
Merged by: @techknowlogick

Base: release/v1.6Head: backport-5570


📝 Commits (2)

  • 76932fe Immediate fix to htmlEncode user added text
  • 7cda1a8 Merge branch 'release/v1.6' into backport-5570

📊 Changes

1 file changed (+9 additions, -5 deletions)

View changed files

📝 public/js/index.js (+9 -5)

📄 Description

There are likely problems remaining with the way that initCommentForm
is creating its elements. I suspect that a malformed avatar url could
be used maliciously.

#5570


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/5575 **Author:** [@techknowlogick](https://github.com/techknowlogick) **Created:** 12/21/2018 **Status:** ✅ Merged **Merged:** 12/21/2018 **Merged by:** [@techknowlogick](https://github.com/techknowlogick) **Base:** `release/v1.6` ← **Head:** `backport-5570` --- ### 📝 Commits (2) - [`76932fe`](https://github.com/go-gitea/gitea/commit/76932fed300ee0801898a7ed3179f47b7d810d8a) Immediate fix to htmlEncode user added text - [`7cda1a8`](https://github.com/go-gitea/gitea/commit/7cda1a83f4fbc4157e1cca278decb1a7215d4999) Merge branch 'release/v1.6' into backport-5570 ### 📊 Changes **1 file changed** (+9 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `public/js/index.js` (+9 -5) </details> ### 📄 Description There are likely problems remaining with the way that initCommentForm is creating its elements. I suspect that a malformed avatar url could be used maliciously. #5570 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 16:16:03 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#17852