[PR #5525] [MERGED] Fix the Let's Encrypt handler by listening on a valid address #17829

New Issue

GiteaMirror · 2025-11-02T16:05:11-06:00

GiteaMirror commented

2025-11-02 16:05:11 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/5525
Author: @gregkare
Created: 12/11/2018
Status: ✅ Merged
Merged: 12/11/2018
Merged by: @techknowlogick

Base: master ← Head: bugfix/5280-fix_letsencrypt

📝 Commits (3)

91aa7dc Fix the Let's Encrypt handler by listening on a valid address
7b43d6a Fix a typo
0f7a5b7 Merge branch 'master' into bugfix/5280-fix_letsencrypt

📊 Changes

1 file changed (+7 additions, -1 deletions)

View changed files

📝 cmd/web.go (+7 -1)

📄 Description

Also handle errors in the HTTP server go routine, return a fatal error when something goes wrong.

Thanks to @gbl08ma for finding the actual bug

Here is an example of the error handling:

2018/12/11 14:23:07 [....io/gitea/cmd/web.go:87 func1()] [E] Failed to
start the Let's Encrypt handler on port 30: listen tcp 0.0.0.0:30: bind:
permission denied

Closes #5280, replaces #5524 (pushed to the wrong organization)

Edit: This is my first Go pull request so I am open to suggestions about the error handling

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/5525 **Author:** [@gregkare](https://github.com/gregkare) **Created:** 12/11/2018 **Status:** ✅ Merged **Merged:** 12/11/2018 **Merged by:** [@techknowlogick](https://github.com/techknowlogick) **Base:** `master` ← **Head:** `bugfix/5280-fix_letsencrypt` --- ### 📝 Commits (3) - [`91aa7dc`](https://github.com/go-gitea/gitea/commit/91aa7dc3c0e3c1426a42aafeacf2dfee7cf403da) Fix the Let's Encrypt handler by listening on a valid address - [`7b43d6a`](https://github.com/go-gitea/gitea/commit/7b43d6a55ca3ec29ed68617dd6220d1dba547d7c) Fix a typo - [`0f7a5b7`](https://github.com/go-gitea/gitea/commit/0f7a5b78c19db0347337a846f6452d57b8a5c26a) Merge branch 'master' into bugfix/5280-fix_letsencrypt ### 📊 Changes **1 file changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `cmd/web.go` (+7 -1) </details> ### 📄 Description Also handle errors in the HTTP server go routine, return a fatal error when something goes wrong. Thanks to @gbl08ma for finding the actual bug Here is an example of the error handling: 2018/12/11 14:23:07 [....io/gitea/cmd/web.go:87 func1()] [E] Failed to start the Let's Encrypt handler on port 30: listen tcp 0.0.0.0:30: bind: permission denied Closes #5280, replaces #5524 (pushed to the wrong organization) Edit: This is my first Go pull request so I am open to suggestions about the error handling --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 16:05:11 -06:00

GiteaMirror closed this issue

2025-11-02 16:05:15 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#17829