github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-18 22:22:24 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #5405] [MERGED] fix password variable shadowing #17786

New Issue
Closed
opened 2025-11-02 15:46:52 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 15:46:52 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/5405
Author: @adelowo
Created: 11/26/2018
Status: ✅ Merged
Merged: 11/26/2018
Merged by: @lafriks

Base: master ← Head: fix_shadowed_variable

📝 Commits (1)

  • 31096c9 fix password variable shadowing

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 cmd/admin.go (+2 -1)

📄 Description

My bad. While the password is randomly generated, it doesn't actually get stored in
the original password variable as it is declared in a new scope with :=.

So an empty string will always be the password anytime -random-password-length is used

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/5405 **Author:** [@adelowo](https://github.com/adelowo) **Created:** 11/26/2018 **Status:** ✅ Merged **Merged:** 11/26/2018 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `master` ← **Head:** `fix_shadowed_variable` --- ### 📝 Commits (1) - [`31096c9`](https://github.com/go-gitea/gitea/commit/31096c96dc8fa3d3ffafce19da18a49b5313a2f1) fix password variable shadowing ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `cmd/admin.go` (+2 -1) </details> ### 📄 Description My bad. While the password is randomly generated, it doesn't actually get stored in the original `password` variable as it is declared in a new scope with `:=`. So an empty string will always be the password anytime `-random-password-length` is used --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 15:46:52 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#17786
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?