github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-05-21 11:55:31 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #5305] [MERGED] Comments list performance optimization #17748

New Issue
Closed
opened 2025-11-02 15:29:33 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 15:29:33 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/5305
Author: @lunny
Created: 11/9/2018
Status: ✅ Merged
Merged: 4/18/2019
Merged by: @techknowlogick

Base: master ← Head: lunny/comment_list

📝 Commits (10+)

📊 Changes

4 files changed (+553 additions, -40 deletions)

View changed files

📝 models/issue.go (+4 -0)
📝 models/issue_comment.go (+40 -26)
📝 models/issue_comment_list.go (+489 -9)
📝 routers/api/v1/repo/issue_comment.go (+20 -5)

📄 Description

Will also fix #5297

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/5305 **Author:** [@lunny](https://github.com/lunny) **Created:** 11/9/2018 **Status:** ✅ Merged **Merged:** 4/18/2019 **Merged by:** [@techknowlogick](https://github.com/techknowlogick) **Base:** `master` ← **Head:** `lunny/comment_list` --- ### 📝 Commits (10+) - [`097ba8b`](https://github.com/go-gitea/gitea/commit/097ba8bcfbdaf7c1b5ad1adfe30ff3a337443d6a) performance optimization - [`7e681e4`](https://github.com/go-gitea/gitea/commit/7e681e4784318388a2b1719883c6531759e64baf) remove unused comment - [`3d0d4a9`](https://github.com/go-gitea/gitea/commit/3d0d4a962056ec3d436d4a2221ed9759a891bd04) load missing attributes on CommentList LoadAttributes - [`11f7317`](https://github.com/go-gitea/gitea/commit/11f73179c38845a6a008de293ecf23ecfde1f131) fix tests - [`8a49268`](https://github.com/go-gitea/gitea/commit/8a49268a8424967c96e8c2511059fe5df8275f90) fix bugs - [`1f0a576`](https://github.com/go-gitea/gitea/commit/1f0a5768af5ba532f1494e5f241ed21c83145f47) fix typo - [`6775859`](https://github.com/go-gitea/gitea/commit/67758593c18def0a9c538fbc1ae20310bb59e17f) fix comment of function - [`05cfe66`](https://github.com/go-gitea/gitea/commit/05cfe668ec95571a8fb58125199548733a4afb1b) fix Comment List's Issues - [`cf73487`](https://github.com/go-gitea/gitea/commit/cf734872346b43af1fdeba96ec880c6a8f5087ed) fix bug - [`fe5f0b7`](https://github.com/go-gitea/gitea/commit/fe5f0b768bccd3b672af50f866dbcf140bc0a865) some improvements ### 📊 Changes **4 files changed** (+553 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `models/issue.go` (+4 -0) 📝 `models/issue_comment.go` (+40 -26) 📝 `models/issue_comment_list.go` (+489 -9) 📝 `routers/api/v1/repo/issue_comment.go` (+20 -5) </details> ### 📄 Description Will also fix #5297 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 15:29:33 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#17748
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?