github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-09 12:46:42 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #5239] [CLOSED] Fix comment box not showing on PR commit replies #17717

New Issue
Closed
opened 2025-11-02 15:15:26 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 15:15:26 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/5239
Author: @jamesa
Created: 10/31/2018
Status: ❌ Closed

Base: master ← Head: fix-comment-box

📝 Commits (3)

  • d9abe4e Fix comment box not showing on PR commit replies
  • 41f86ad Merge branch 'master' into fix-comment-box
  • 137116b Merge branch 'master' into fix-comment-box

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 public/js/index.js (+2 -1)

📄 Description

Fixes #5237

The form that gets revealed when clicking on the "Reply" button mentioned in #5237, and the button, do not share the same parent. The button ends up getting wrapped in a link which causes this issue.

I have no idea how or why this worked on the English translation though. Didn't dig in that deep. :)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/5239 **Author:** [@jamesa](https://github.com/jamesa) **Created:** 10/31/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-comment-box` --- ### 📝 Commits (3) - [`d9abe4e`](https://github.com/go-gitea/gitea/commit/d9abe4ea3098cc693616e26c358967c63498b119) Fix comment box not showing on PR commit replies - [`41f86ad`](https://github.com/go-gitea/gitea/commit/41f86ad04d550d62c7d79faf846a9517d94ab7b2) Merge branch 'master' into fix-comment-box - [`137116b`](https://github.com/go-gitea/gitea/commit/137116b40befb8e2519431a73a081c09c133a2c9) Merge branch 'master' into fix-comment-box ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `public/js/index.js` (+2 -1) </details> ### 📄 Description Fixes #5237 The form that gets revealed when clicking on the "Reply" button mentioned in #5237, and the button, do not share the same parent. The button ends up getting wrapped in a link which causes this issue. I have no idea how or why this worked on the English translation though. Didn't dig in that deep. :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 15:15:26 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#17717
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?