[PR #5137] [MERGED] Fix SQL quoting #17664

Closed
opened 2025-11-02 14:51:03 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/5137
Author: @filipnavara
Created: 10/22/2018
Status: Merged
Merged: 10/22/2018
Merged by: @techknowlogick

Base: release/v1.6Head: patch-1-v1.6


📝 Commits (1)

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 models/user_openid.go (+1 -1)

📄 Description

Backport of #5117.

show is keyword in MySQL and has to be quoted to reference a column name. Use grave accents (ASCII code 96) for quoting to match rest of the source code. It's non-standard SQL, but it's supported by SQLite and MySQL.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/5137 **Author:** [@filipnavara](https://github.com/filipnavara) **Created:** 10/22/2018 **Status:** ✅ Merged **Merged:** 10/22/2018 **Merged by:** [@techknowlogick](https://github.com/techknowlogick) **Base:** `release/v1.6` ← **Head:** `patch-1-v1.6` --- ### 📝 Commits (1) - [`6ab29ed`](https://github.com/go-gitea/gitea/commit/6ab29ed6e6df2ad13646c9fd840f697ab2b360b2) Fix SQL quoting ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `models/user_openid.go` (+1 -1) </details> ### 📄 Description Backport of #5117. `show` is keyword in MySQL and has to be quoted to reference a column name. Use grave accents (ASCII code 96) for quoting to match rest of the source code. It's non-standard SQL, but it's supported by SQLite and MySQL. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 14:51:03 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#17664