[PR #5132] [MERGED] Show review summary in pull requests #17660

New Issue

GiteaMirror · 2025-11-02T14:49:39-06:00

GiteaMirror commented

2025-11-02 14:49:39 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/5132
Author: @kolaente
Created: 10/20/2018
Status: ✅ Merged
Merged: 11/22/2018
Merged by: @lafriks

Base: master ← Head: feature/review-summary

📝 Commits (10+)

b555fd3 Added basic function to get reviewers with their review statuses by issue
c58a61c Reviewers are now shown in the ui
5b10388 Fixed review time
ea1626e add il8n
e5062e4 Merge branch 'master' into feature/review-summary
ce094e1 Only show reject and approve pr comments in summary
45f061a Only show newest pr comments in summary
ab6657f fixed sorting
2146c92 Fixed heatmap in postgresql
34419ba Merge branch 'master' into feature/review-summary

📊 Changes

8 files changed (+179 additions, -2 deletions)

View changed files

📝 models/fixtures/review.yml (+40 -0)
📝 models/review.go (+33 -0)
📝 models/review_test.go (+31 -1)
📝 options/locale/locale_en-US.ini (+1 -0)
📝 public/css/index.css (+1 -1)
📝 public/less/_repository.less (+32 -0)
📝 routers/repo/issue.go (+6 -0)
📝 templates/repo/issue/view_content/pull.tmpl (+35 -0)

📄 Description

Resolves #4390.

This pr implements a review summary on the bottom of a pr as disscussed in #4390.

It currently shows every review grouped by type and user. This means if a user rejects a pr and later approves it, both are shown in the summary (with their dates). Should I keep this behaviour or show only the newest (grouped by user)?

Screenshot

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/5132 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 10/20/2018 **Status:** ✅ Merged **Merged:** 11/22/2018 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `master` ← **Head:** `feature/review-summary` --- ### 📝 Commits (10+) - [`b555fd3`](https://github.com/go-gitea/gitea/commit/b555fd370e6c70ca24e2922428f01a977a83a8dd) Added basic function to get reviewers with their review statuses by issue - [`c58a61c`](https://github.com/go-gitea/gitea/commit/c58a61c856c2e64c44b7da544d1509567096fac8) Reviewers are now shown in the ui - [`5b10388`](https://github.com/go-gitea/gitea/commit/5b10388641399ba53c3af685498a436c985844f9) Fixed review time - [`ea1626e`](https://github.com/go-gitea/gitea/commit/ea1626ef3d1fc940a260e61357f70d5eb5db0f82) add il8n - [`e5062e4`](https://github.com/go-gitea/gitea/commit/e5062e493125504a6a1fafcb2f8840709c8319c2) Merge branch 'master' into feature/review-summary - [`ce094e1`](https://github.com/go-gitea/gitea/commit/ce094e1d15e83ee47ef9900a559e3a0316e9beb9) Only show reject and approve pr comments in summary - [`45f061a`](https://github.com/go-gitea/gitea/commit/45f061a89f4960f7e3e2d189ec6f44a63513ff09) Only show newest pr comments in summary - [`ab6657f`](https://github.com/go-gitea/gitea/commit/ab6657f9a9dc76b62fcab6a74ffe9b7589d5021d) fixed sorting - [`2146c92`](https://github.com/go-gitea/gitea/commit/2146c92b9795e1b6044d87953bb714e99ce801b3) Fixed heatmap in postgresql - [`34419ba`](https://github.com/go-gitea/gitea/commit/34419ba741096074c9fff5eb92a3e7dbe0b16508) Merge branch 'master' into feature/review-summary ### 📊 Changes **8 files changed** (+179 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `models/fixtures/review.yml` (+40 -0) 📝 `models/review.go` (+33 -0) 📝 `models/review_test.go` (+31 -1) 📝 `options/locale/locale_en-US.ini` (+1 -0) 📝 `public/css/index.css` (+1 -1) 📝 `public/less/_repository.less` (+32 -0) 📝 `routers/repo/issue.go` (+6 -0) 📝 `templates/repo/issue/view_content/pull.tmpl` (+35 -0) </details> ### 📄 Description Resolves #4390. This pr implements a review summary on the bottom of a pr as disscussed in #4390. It currently shows every review grouped by type and user. This means if a user rejects a pr and later approves it, both are shown in the summary (with their dates). Should I keep this behaviour or show only the newest (grouped by user)? #### Screenshot ![image](https://user-images.githubusercontent.com/13721712/47261033-01e27980-d4c7-11e8-8021-d5e6dec9dd7b.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 14:49:39 -06:00

GiteaMirror closed this issue

2025-11-02 14:49:40 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#17660