github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-09 12:46:42 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #5110] [MERGED] Refactor mail notification #17644

New Issue
Closed
opened 2025-11-02 14:41:18 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 14:41:18 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/5110
Author: @lunny
Created: 10/19/2018
Status: ✅ Merged
Merged: 1/13/2019
Merged by: @lafriks

Base: master ← Head: lunny/notification_mail

📝 Commits (3)

  • 4ab7928 mail notification implement interface
  • 9d13dc6 fix file comment year
  • b3f3a13 use NullNotifier as parent struct of notifiers

📊 Changes

8 files changed (+190 additions, -55 deletions)

View changed files

📝 models/issue.go (+0 -3)
📝 models/issue_comment.go (+5 -4)
📝 models/pull.go (+0 -2)
📝 modules/notification/base/notifier.go (+0 -0)
➕ modules/notification/base/null.go (+108 -0)
➕ modules/notification/mail/mail.go (+74 -0)
📝 modules/notification/notification.go (+2 -0)
📝 modules/notification/ui/ui.go (+1 -46)

📄 Description

extract from #4001

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/5110 **Author:** [@lunny](https://github.com/lunny) **Created:** 10/19/2018 **Status:** ✅ Merged **Merged:** 1/13/2019 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `master` ← **Head:** `lunny/notification_mail` --- ### 📝 Commits (3) - [`4ab7928`](https://github.com/go-gitea/gitea/commit/4ab79283d32c6ccedd6de25e1a4e6a52b8a096df) mail notification implement interface - [`9d13dc6`](https://github.com/go-gitea/gitea/commit/9d13dc69a45a95431500ba50b8dc4f24b388090d) fix file comment year - [`b3f3a13`](https://github.com/go-gitea/gitea/commit/b3f3a13e7be4bbbb0963de2c5b62dae5019cbdc4) use NullNotifier as parent struct of notifiers ### 📊 Changes **8 files changed** (+190 additions, -55 deletions) <details> <summary>View changed files</summary> 📝 `models/issue.go` (+0 -3) 📝 `models/issue_comment.go` (+5 -4) 📝 `models/pull.go` (+0 -2) 📝 `modules/notification/base/notifier.go` (+0 -0) ➕ `modules/notification/base/null.go` (+108 -0) ➕ `modules/notification/mail/mail.go` (+74 -0) 📝 `modules/notification/notification.go` (+2 -0) 📝 `modules/notification/ui/ui.go` (+1 -46) </details> ### 📄 Description extract from #4001 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 14:41:18 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#17644
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?