[PR #5104] [MERGED] Add comment replies #17643

New Issue

GiteaMirror · 2025-11-02T14:40:47-06:00

GiteaMirror commented

2025-11-02 14:40:47 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/5104
Author: @jonasfranz
Created: 10/18/2018
Status: ✅ Merged
Merged: 10/22/2018
Merged by: @techknowlogick

Base: master ← Head: enhancement/review-replies

📝 Commits (5)

8633c3f Add comment replies
144ed27 Merge branch 'master' into enhancement/review-replies
15cb19a Replace reviewID with review.ID
43a86e1 Merge remote-tracking branch 'jonas/enhancement/review-replies' into enhancement/review-replies
2ec4c9d Merge branch 'master' into enhancement/review-replies

📊 Changes

6 files changed (+14 additions, -10 deletions)

View changed files

📝 modules/auth/repo_form.go (+1 -0)
📝 routers/repo/pull_review.go (+4 -1)
📝 templates/repo/diff/box.tmpl (+2 -2)
📝 templates/repo/diff/comment_form.tmpl (+5 -5)
📝 templates/repo/diff/section_unified.tmpl (+1 -1)
📝 templates/repo/issue/view_content/comments.tmpl (+1 -1)

📄 Description

Partially fixes #4389 and #5100.

This PR makes it possible to reply to review comments. These replies will be also shown at the "Conversation" tab.

At the moment it is only possible to reply to comments if there is already a review at the specific line. That can be fixed, but requires translations. We should discuss about including this in 1.6.

Without this enhancement the review comment feature seems buggy to the end user.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/5104 **Author:** [@jonasfranz](https://github.com/jonasfranz) **Created:** 10/18/2018 **Status:** ✅ Merged **Merged:** 10/22/2018 **Merged by:** [@techknowlogick](https://github.com/techknowlogick) **Base:** `master` ← **Head:** `enhancement/review-replies` --- ### 📝 Commits (5) - [`8633c3f`](https://github.com/go-gitea/gitea/commit/8633c3fe9fc3677aa475fb535da5dc4e3dfd290c) Add comment replies - [`144ed27`](https://github.com/go-gitea/gitea/commit/144ed277c6bf3a5f75fad32952439f7e9ec0d97f) Merge branch 'master' into enhancement/review-replies - [`15cb19a`](https://github.com/go-gitea/gitea/commit/15cb19af4d3a0e908cd55ae4916376b41c19b3d8) Replace reviewID with review.ID - [`43a86e1`](https://github.com/go-gitea/gitea/commit/43a86e16cb4cf44b4153161db864c43ba9bc2f94) Merge remote-tracking branch 'jonas/enhancement/review-replies' into enhancement/review-replies - [`2ec4c9d`](https://github.com/go-gitea/gitea/commit/2ec4c9dc34e67f00a6bcfa31c60d49aa6f7337e3) Merge branch 'master' into enhancement/review-replies ### 📊 Changes **6 files changed** (+14 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `modules/auth/repo_form.go` (+1 -0) 📝 `routers/repo/pull_review.go` (+4 -1) 📝 `templates/repo/diff/box.tmpl` (+2 -2) 📝 `templates/repo/diff/comment_form.tmpl` (+5 -5) 📝 `templates/repo/diff/section_unified.tmpl` (+1 -1) 📝 `templates/repo/issue/view_content/comments.tmpl` (+1 -1) </details> ### 📄 Description Partially fixes #4389 and #5100. This PR makes it possible to reply to review comments. These replies will be also shown at the "Conversation" tab. At the moment it is only possible to reply to comments if there is already a review at the specific line. That can be fixed, but requires translations. We should discuss about including this in 1.6. Without this enhancement the review comment feature seems buggy to the end user. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 14:40:47 -06:00

GiteaMirror closed this issue

2025-11-02 14:40:53 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#17643