[PR #5102] [MERGED] Fix home page template regression #17642

New Issue

GiteaMirror · 2025-11-02T14:40:04-06:00

GiteaMirror commented

2025-11-02 14:40:04 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/5102
Author: @darktohka
Created: 10/18/2018
Status: ✅ Merged
Merged: 10/18/2018
Merged by: @lunny

Base: master ← Head: home-regression

📝 Commits (2)

2e1d3d0 Fix home page template regression
81fc32a Merge branch 'master' into home-regression

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 templates/home.tmpl (+1 -1)

📄 Description

Commit 7bb4d610e5 tries to take the app_name from the locale, however, it is a user defined setting. This causes the app name to simply display as app_name instead of the correct value.

templates/helper.go automatically injects the AppName variable into every template, so we can safely use that instead.

Right now, the home page looks like this: https://i.imgur.com/aZKaotf.png

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/5102 **Author:** [@darktohka](https://github.com/darktohka) **Created:** 10/18/2018 **Status:** ✅ Merged **Merged:** 10/18/2018 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `home-regression` --- ### 📝 Commits (2) - [`2e1d3d0`](https://github.com/go-gitea/gitea/commit/2e1d3d0b5a80e565705acf0487345b69e949d17e) Fix home page template regression - [`81fc32a`](https://github.com/go-gitea/gitea/commit/81fc32aad756cc25fea36e4b8ffe58f933ed408c) Merge branch 'master' into home-regression ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `templates/home.tmpl` (+1 -1) </details> ### 📄 Description Commit 7bb4d610e5cca7ad514e377d2b36254a4cfee5b9 tries to take the app_name from the locale, however, it is a user defined setting. This causes the app name to simply display as `app_name` instead of the correct value. templates/helper.go automatically injects the AppName variable into every template, so we can safely use that instead. Right now, the home page looks like this: https://i.imgur.com/aZKaotf.png --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 14:40:04 -06:00

GiteaMirror closed this issue

2025-11-02 14:40:11 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#17642