github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-09 12:46:42 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #5094] [MERGED] Fix issue where ecdsa and other key types are not synced from LDAP (#5092) #17635

New Issue
Closed
opened 2025-11-02 14:37:35 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 14:37:35 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/5094
Author: @xor-gate
Created: 10/17/2018
Status: ✅ Merged
Merged: 10/31/2018
Merged by: @techknowlogick

Base: master ← Head: feature/issue-5092

📝 Commits (10+)

  • da2ff25 Fix issue where ecdsa and other key types are not synced from LDAP authentication provider fixes #5092
  • 2e5c3d0 Merge branch 'master' into feature/issue-5092
  • 83f6eec Merge branch 'master' into feature/issue-5092
  • 2a57643 Merge branch 'master' into feature/issue-5092
  • 53c0181 Merge branch 'master' into feature/issue-5092
  • e2292c7 Merge branch 'master' into feature/issue-5092
  • e4cca7e Merge branch 'master' into feature/issue-5092
  • c3321ed Merge branch 'master' into feature/issue-5092
  • ea384de Merge branch 'master' into feature/issue-5092
  • 2eae1b1 Merge branch 'master' into feature/issue-5092

📊 Changes

2 files changed (+4 additions, -1 deletions)

View changed files

📝 integrations/auth_ldap_test.go (+1 -0)
📝 models/user.go (+3 -1)

📄 Description

Implements #5092

Currently LDAP sync support only ssh prefixed keytypes, so other keytypes are simply ignored. This PR improves the check by using the native parsing of the public authorized key line. I tried to find out to add a test ecdsa key but not sure where to place it.

I think this are only the calculated fingerprints:

https://github.com/go-gitea/gitea/blob/master/integrations/auth_ldap_test.go#L43-L46

Based on this

https://github.com/go-gitea/gitea/blob/master/integrations/api_admin_test.go
or this
https://github.com/go-gitea/gitea/blob/master/integrations/api_keys_test.go

I would like some advice on the test, as it is highly valuable.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/5094 **Author:** [@xor-gate](https://github.com/xor-gate) **Created:** 10/17/2018 **Status:** ✅ Merged **Merged:** 10/31/2018 **Merged by:** [@techknowlogick](https://github.com/techknowlogick) **Base:** `master` ← **Head:** `feature/issue-5092` --- ### 📝 Commits (10+) - [`da2ff25`](https://github.com/go-gitea/gitea/commit/da2ff250ebda2ee08111fa8a5b03be382bb0fca2) Fix issue where ecdsa and other key types are not synced from LDAP authentication provider fixes #5092 - [`2e5c3d0`](https://github.com/go-gitea/gitea/commit/2e5c3d0c9a387bdcc2458a69df503c15edfd5552) Merge branch 'master' into feature/issue-5092 - [`83f6eec`](https://github.com/go-gitea/gitea/commit/83f6eecc3943233f06bb24d494b1f20f91ac5e88) Merge branch 'master' into feature/issue-5092 - [`2a57643`](https://github.com/go-gitea/gitea/commit/2a57643fe214c141438d89499be90b29a8464858) Merge branch 'master' into feature/issue-5092 - [`53c0181`](https://github.com/go-gitea/gitea/commit/53c0181cf810a90e5d21189dae46c25f85e7d77a) Merge branch 'master' into feature/issue-5092 - [`e2292c7`](https://github.com/go-gitea/gitea/commit/e2292c7a1c42e024ed6da313fac91228c2a31746) Merge branch 'master' into feature/issue-5092 - [`e4cca7e`](https://github.com/go-gitea/gitea/commit/e4cca7eb80d69b7eae9d836f6f55939286c65f43) Merge branch 'master' into feature/issue-5092 - [`c3321ed`](https://github.com/go-gitea/gitea/commit/c3321edb967683ac23f1b159f981d526bf7f3bd2) Merge branch 'master' into feature/issue-5092 - [`ea384de`](https://github.com/go-gitea/gitea/commit/ea384dee7582ef1f830eb1db06e19a060755cc9d) Merge branch 'master' into feature/issue-5092 - [`2eae1b1`](https://github.com/go-gitea/gitea/commit/2eae1b14e37eed6f23895594af7b193b7c920ef1) Merge branch 'master' into feature/issue-5092 ### 📊 Changes **2 files changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `integrations/auth_ldap_test.go` (+1 -0) 📝 `models/user.go` (+3 -1) </details> ### 📄 Description Implements #5092 Currently LDAP sync support only `ssh` prefixed keytypes, so other keytypes are simply ignored. This PR improves the check by using the native parsing of the public authorized key line. I tried to find out to add a test ecdsa key but not sure where to place it. I think this are only the calculated fingerprints: https://github.com/go-gitea/gitea/blob/master/integrations/auth_ldap_test.go#L43-L46 Based on this https://github.com/go-gitea/gitea/blob/master/integrations/api_admin_test.go or this https://github.com/go-gitea/gitea/blob/master/integrations/api_keys_test.go I would like some advice on the test, as it is highly valuable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 14:37:35 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#17635
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?