[PR #5085] [MERGED] Add notification interface and refactor UI notifications #17628

New Issue

GiteaMirror · 2025-11-02T14:35:00-06:00

GiteaMirror commented

2025-11-02 14:35:00 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/5085
Author: @lunny
Created: 10/15/2018
Status: ✅ Merged
Merged: 10/18/2018
Merged by: @lunny

Base: master ← Head: lunny/notification_ui

📝 Commits (3)

00539b2 add notification interface and refactor UI notifications
d608022 add missing methods on notification interface and notifiy only issue status really changed
ef91809 implement NotifyPullRequestReview for ui notification

📊 Changes

11 files changed (+376 additions, -42 deletions)

View changed files

📝 models/issue.go (+4 -0)
📝 models/review.go (+2 -0)
➕ modules/notification/base/base.go (+43 -0)
📝 modules/notification/notification.go (+153 -28)
➕ modules/notification/ui/ui.go (+134 -0)
📝 routers/api/v1/repo/issue.go (+5 -0)
📝 routers/api/v1/repo/issue_comment.go (+3 -0)
📝 routers/api/v1/repo/pull.go (+5 -0)
📝 routers/repo/issue.go (+16 -11)
📝 routers/repo/pull.go (+2 -2)
📝 routers/repo/pull_review.go (+9 -1)

📄 Description

This pull request create a notification interface so that all notifications, i.e. ui, actions, webhooks, mails and etc. will only need to implement the interface. So that the code will be more easy. This is extract from #4001. It's the first step of serval pull requests from #4001. I think it will be easier to review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/5085 **Author:** [@lunny](https://github.com/lunny) **Created:** 10/15/2018 **Status:** ✅ Merged **Merged:** 10/18/2018 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `lunny/notification_ui` --- ### 📝 Commits (3) - [`00539b2`](https://github.com/go-gitea/gitea/commit/00539b2ab7a1cbff9cb1f2435cb838c94543ea54) add notification interface and refactor UI notifications - [`d608022`](https://github.com/go-gitea/gitea/commit/d60802289cd3532d11ab1d834e266b477bf7440a) add missing methods on notification interface and notifiy only issue status really changed - [`ef91809`](https://github.com/go-gitea/gitea/commit/ef91809e41011d39a98a593f1f0af2fb9b13c144) implement NotifyPullRequestReview for ui notification ### 📊 Changes **11 files changed** (+376 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `models/issue.go` (+4 -0) 📝 `models/review.go` (+2 -0) ➕ `modules/notification/base/base.go` (+43 -0) 📝 `modules/notification/notification.go` (+153 -28) ➕ `modules/notification/ui/ui.go` (+134 -0) 📝 `routers/api/v1/repo/issue.go` (+5 -0) 📝 `routers/api/v1/repo/issue_comment.go` (+3 -0) 📝 `routers/api/v1/repo/pull.go` (+5 -0) 📝 `routers/repo/issue.go` (+16 -11) 📝 `routers/repo/pull.go` (+2 -2) 📝 `routers/repo/pull_review.go` (+9 -1) </details> ### 📄 Description This pull request create a notification interface so that all notifications, i.e. ui, actions, webhooks, mails and etc. will only need to implement the interface. So that the code will be more easy. This is extract from #4001. It's the first step of serval pull requests from #4001. I think it will be easier to review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 14:35:00 -06:00

GiteaMirror closed this issue

2025-11-02 14:35:02 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#17628