[PR #5064] [MERGED] only chown directories during docker setup if necessary. Fix #4425 #17621

Closed
opened 2025-11-02 14:31:35 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/5064
Author: @fabian-braun
Created: 10/10/2018
Status: Merged
Merged: 10/30/2018
Merged by: @techknowlogick

Base: masterHead: master


📝 Commits (5)

  • ed41ebb only chown directories during docker setup if necessary. Fix #4425
  • 215529f Merge branch 'master' into master
  • e7132d7 Merge branch 'master' into master
  • ffc287e Merge branch 'master' into master
  • d6d7496 Merge branch 'master' into master

📊 Changes

1 file changed (+4 additions, -1 deletions)

View changed files

📝 docker/etc/s6/gitea/setup (+4 -1)

📄 Description

This PR fixes issue #4425 .
Instead of blindly running chown during setup, we check that the directory is not already owned by the correct user. Currently the check is non-recursive for speed (only checks the ownership of top-level directory).


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/5064 **Author:** [@fabian-braun](https://github.com/fabian-braun) **Created:** 10/10/2018 **Status:** ✅ Merged **Merged:** 10/30/2018 **Merged by:** [@techknowlogick](https://github.com/techknowlogick) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (5) - [`ed41ebb`](https://github.com/go-gitea/gitea/commit/ed41ebb635af94d66dbaab1327564c48e67e98f5) only chown directories during docker setup if necessary. Fix #4425 - [`215529f`](https://github.com/go-gitea/gitea/commit/215529fa171a58d36bf27c928bb5297d8d5e8420) Merge branch 'master' into master - [`e7132d7`](https://github.com/go-gitea/gitea/commit/e7132d73e3cd4dfc441f3d0efc2082884eb2b00d) Merge branch 'master' into master - [`ffc287e`](https://github.com/go-gitea/gitea/commit/ffc287e546fb25db8896a4e112c71f2946fcfd8d) Merge branch 'master' into master - [`d6d7496`](https://github.com/go-gitea/gitea/commit/d6d74964ccf7c370dae13b4289a9b7cf0a245494) Merge branch 'master' into master ### 📊 Changes **1 file changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `docker/etc/s6/gitea/setup` (+4 -1) </details> ### 📄 Description This PR fixes issue #4425 . Instead of blindly running `chown` during setup, we check that the directory is not already owned by the correct user. Currently the check is non-recursive for speed (only checks the ownership of top-level directory). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 14:31:35 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#17621