[PR #5033] [CLOSED] UX treat register like sign in, even oauth #17604

New Issue

GiteaMirror · 2025-11-02T14:23:27-06:00

GiteaMirror commented

2025-11-02 14:23:27 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/5033
Author: @coolaj86
Created: 10/7/2018
Status: ❌ Closed

Base: main ← Head: ux-register-is-signin

📝 Commits (3)

c003070 treat register like sign in, even oauth
4db045b Merge branch 'master' into ux-register-is-signin
b655b35 Merge branch 'master' into ux-register-is-signin

📊 Changes

3 files changed (+60 additions, -56 deletions)

View changed files

📝 modules/auth/user_form.go (+1 -0)
📝 routers/user/auth.go (+51 -56)
📝 templates/user/auth/signup_inner.tmpl (+8 -0)

📄 Description

Re: https://github.com/go-gitea/gitea/issues/4226, https://github.com/go-gitea/gitea/issues/5032,

link oauth-created accounts just like normal ones
- exception: make unlinkable when ALLOW_ONLY_EXTERNAL_REGISTRATION = true
remember me on sign up page
do not require a second login when account is created

If you'd like to test it out

My pull request is against master, but I run it as backport to v1.5.1 (includes https://github.com/go-gitea/gitea/pull/5006, https://github.com/go-gitea/gitea/pull/5029, https://github.com/go-gitea/gitea/pull/5033):

git clone https://github.com/coolaj86/gitea.git gitea.coolaj86 -b v1.5.1-coolaj86
pushd gitea.coolaj86
TAGS="bindata sqlite" make generate all

I would not recommend replacing your existing gitea, but rather creating a symlink so that you can easily switch back if you don't like it. For example, if you keep gitea in /opt/gitea/bin:

rsync -av ./gitea /opt/gitea/bin/gitea-v1.5.1-coolaj86
pushd /opt/gitea/bin
mv gitea gitea-v1.5.1
ln -s gitea-v1.5.1-coolaj86 gitea

I've run a couple of manual tests so far, so I feel comfortable with someone else trying it out. I won't be pushing any additional changes to that branch (such as the upcoming changes to address the empty checkboxes in the issue) until I've tested them in production for myself.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/5033 **Author:** [@coolaj86](https://github.com/coolaj86) **Created:** 10/7/2018 **Status:** ❌ Closed **Base:** `main` ← **Head:** `ux-register-is-signin` --- ### 📝 Commits (3) - [`c003070`](https://github.com/go-gitea/gitea/commit/c003070b563c68a6553ee8fdb42f047e524be7cd) treat register like sign in, even oauth - [`4db045b`](https://github.com/go-gitea/gitea/commit/4db045b1ba7eaf5d3299a7f7af29b84e4a7a25e6) Merge branch 'master' into ux-register-is-signin - [`b655b35`](https://github.com/go-gitea/gitea/commit/b655b352b3c4669c9edb6a14e02274a6183ee319) Merge branch 'master' into ux-register-is-signin ### 📊 Changes **3 files changed** (+60 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `modules/auth/user_form.go` (+1 -0) 📝 `routers/user/auth.go` (+51 -56) 📝 `templates/user/auth/signup_inner.tmpl` (+8 -0) </details> ### 📄 Description Re: https://github.com/go-gitea/gitea/issues/4226, https://github.com/go-gitea/gitea/issues/5032, * [x] link oauth-created accounts just like normal ones * exception: make unlinkable when `ALLOW_ONLY_EXTERNAL_REGISTRATION = true` * [x] `remember me` on sign up page * [x] do not require a second login when account is created  If you'd like to test it out ==== My pull request is against `master`, but [I run it](https://git.coolaj86.com) as backport to v1.5.1 (includes https://github.com/go-gitea/gitea/pull/5006, https://github.com/go-gitea/gitea/pull/5029, https://github.com/go-gitea/gitea/pull/5033): ```bash git clone https://github.com/coolaj86/gitea.git gitea.coolaj86 -b v1.5.1-coolaj86 pushd gitea.coolaj86 TAGS="bindata sqlite" make generate all ``` I would not recommend replacing your existing gitea, but rather creating a symlink so that you can easily switch back if you don't like it. For example, if you keep `gitea` in `/opt/gitea/bin`: ```bash rsync -av ./gitea /opt/gitea/bin/gitea-v1.5.1-coolaj86 pushd /opt/gitea/bin mv gitea gitea-v1.5.1 ln -s gitea-v1.5.1-coolaj86 gitea ``` I've run a couple of manual tests so far, so I feel comfortable with someone else trying it out. I won't be pushing any additional changes to that branch (such as the upcoming changes to address the empty checkboxes in the issue) until I've tested them in production for myself. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 14:23:27 -06:00

GiteaMirror closed this issue

2025-11-02 14:23:34 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#17604