[PR #4981] [MERGED] Show email if the authenticated user owns the profile page being requested for #17577

New Issue

GiteaMirror · 2025-11-02T14:11:24-06:00

GiteaMirror commented

2025-11-02 14:11:24 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/4981
Author: @adelowo
Created: 9/26/2018
Status: ✅ Merged
Merged: 2/19/2019
Merged by: @techknowlogick

Base: master ← Head: dont_hide_email_from_self

📝 Commits (10+)

c2a1a03 Show email if the authenticated user owns the profile page being
9368cfc fix current user check... This prevents a panic as a user must be signed in before ctx.User is called
d09b47d fix panic in tests
c857dd9 try to fix tests
ca89f93 Merge branch 'master' into dont_hide_email_from_self
de8219f Update year
282292e Test CI fail
95da2bb Revert change
c62e8bb User 3 is not allowed to authorize
f046b8d Merge branch 'master' into dont_hide_email_from_self

📊 Changes

4 files changed (+17 additions, -5 deletions)

View changed files

📝 integrations/setting_test.go (+14 -3)
📝 models/fixtures/user.yml (+1 -0)
📝 routers/user/profile.go (+1 -1)
📝 templates/user/profile.tmpl (+1 -1)

📄 Description

Also removed setting.UI.ShowUserEmail as it's documentation says it
only controls the email setting on the explore page

Would fix broken CI, this was pushed in a quick rush

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/4981 **Author:** [@adelowo](https://github.com/adelowo) **Created:** 9/26/2018 **Status:** ✅ Merged **Merged:** 2/19/2019 **Merged by:** [@techknowlogick](https://github.com/techknowlogick) **Base:** `master` ← **Head:** `dont_hide_email_from_self` --- ### 📝 Commits (10+) - [`c2a1a03`](https://github.com/go-gitea/gitea/commit/c2a1a037a817f93345c1bb8ee4910b9efc7d03a8) Show email if the authenticated user owns the profile page being - [`9368cfc`](https://github.com/go-gitea/gitea/commit/9368cfcdd6b5ecfaadee8a8730d310ce1cbf906a) fix current user check... This prevents a panic as a user must be signed in before ctx.User is called - [`d09b47d`](https://github.com/go-gitea/gitea/commit/d09b47d735418c010f03a9e76f5d193a463988a8) fix panic in tests - [`c857dd9`](https://github.com/go-gitea/gitea/commit/c857dd90a17611d4948414cce9fd7a7fd9142f82) try to fix tests - [`ca89f93`](https://github.com/go-gitea/gitea/commit/ca89f9333afe23a8c939596fa40287b58306136b) Merge branch 'master' into dont_hide_email_from_self - [`de8219f`](https://github.com/go-gitea/gitea/commit/de8219f1a5bd4ff3fb0292e33180936699e8c598) Update year - [`282292e`](https://github.com/go-gitea/gitea/commit/282292ee70c804e2fa7a36397851181bf7b1e113) Test CI fail - [`95da2bb`](https://github.com/go-gitea/gitea/commit/95da2bb05a97c33459969c18e3a0ac65d3cb3b7a) Revert change - [`c62e8bb`](https://github.com/go-gitea/gitea/commit/c62e8bbc3eb7744360008275d30a0c39232e4742) User 3 is not allowed to authorize - [`f046b8d`](https://github.com/go-gitea/gitea/commit/f046b8dfa5b7b322fb792d140f8ba11d15e6a9c5) Merge branch 'master' into dont_hide_email_from_self ### 📊 Changes **4 files changed** (+17 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `integrations/setting_test.go` (+14 -3) 📝 `models/fixtures/user.yml` (+1 -0) 📝 `routers/user/profile.go` (+1 -1) 📝 `templates/user/profile.tmpl` (+1 -1) </details> ### 📄 Description Also removed `setting.UI.ShowUserEmail` as it's documentation says it only controls the email setting on the explore page > Would fix broken CI, this was pushed in a quick rush --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 14:11:24 -06:00

GiteaMirror closed this issue

2025-11-02 14:11:24 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#17577