github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #4945] [MERGED] Make sure to catch the right error so it is displayed on the UI #17561

New Issue
Closed
opened 2025-11-02 14:04:50 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 14:04:50 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/4945
Author: @adelowo
Created: 9/16/2018
Status: ✅ Merged
Merged: 9/16/2018
Merged by: @lafriks

Base: master ← Head: catch_the_right_error

📝 Commits (1)

  • c31e9ef make sure to catch the right error so it is displayed as an error on the ui not a 500

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 models/ssh_key.go (+1 -1)
📝 routers/repo/setting.go (+1 -1)

📄 Description

  • Using fmt.Errorf("addDeployKey: %v", err) changes the error type and thus an error page is thrown since it doesn't match all expected cases...
  • Also caught the right error ( ErrDeployKeyAlreadyExist ) instead of a regular ssh key error
screen shot 2018-09-16 at 10 24 04

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/4945 **Author:** [@adelowo](https://github.com/adelowo) **Created:** 9/16/2018 **Status:** ✅ Merged **Merged:** 9/16/2018 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `master` ← **Head:** `catch_the_right_error` --- ### 📝 Commits (1) - [`c31e9ef`](https://github.com/go-gitea/gitea/commit/c31e9ef5ee3c6d555e9fe09f5a24c8f905083f09) make sure to catch the right error so it is displayed as an error on the ui not a 500 ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `models/ssh_key.go` (+1 -1) 📝 `routers/repo/setting.go` (+1 -1) </details> ### 📄 Description - Using `fmt.Errorf("addDeployKey: %v", err)` ___changes the error type___ and thus an error page is thrown since it doesn't match all expected cases... - Also caught the right error ( `ErrDeployKeyAlreadyExist` ) instead of a regular ssh key error <img width="1920" alt="screen shot 2018-09-16 at 10 24 04" src="https://user-images.githubusercontent.com/12677701/45594926-fa492580-b99a-11e8-9fb5-fa36db1fa45b.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 14:04:50 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#17561
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?