[PR #4878] [MERGED] Fix #4877 to follow the OpenID Connect Audiences spec #17532

New Issue

GiteaMirror · 2025-11-02T13:54:18-06:00

GiteaMirror commented

2025-11-02 13:54:18 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/4878
Author: @OvermindDL1
Created: 9/6/2018
Status: ✅ Merged
Merged: 9/20/2018
Merged by: @lafriks

Base: master ← Head: patch-1

📝 Commits (4)

1010a88 Fix #4877 to follow the OpenID Connect Audiences spec
6db8b26 Update goth dependency
b3332e2 Merge branch 'master' into patch-1
c7872ca Merge branch 'master' into patch-1

📊 Changes

2 files changed (+32 additions, -4 deletions)

View changed files

📝 Gopkg.lock (+3 -3)
📝 vendor/github.com/markbates/goth/providers/openidConnect/openidConnect.go (+29 -1)

📄 Description

This follows the OpenID Connect spec to support audiences with either a string or an array of strings instead of just a string.

This might want to be on the release branches as well as it is a bug fix, but I personally can use master until then.

I have tested this and am running it on my site now with the OpenID Connect with multiple audiences returned with no issue, the new code is not even run at all unless the old pure-string check fails.

Disclaimer: I've never used and barely looked at Go thus far, and I was unable to find common functions like filter or so forth (or any higher order functions at all...) and based on some googling it appears that these large and unwieldy loops are the standard way to do this kind of thing in Go, but if any changes are needed please request as such with information on what I should change it to (great learning opportunity!).

And of course any rights or whatever there-of related to this code I give up for whatever use this project currently wants or will want in the future. Etc... etc... Commit is signed, etc...

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/4878 **Author:** [@OvermindDL1](https://github.com/OvermindDL1) **Created:** 9/6/2018 **Status:** ✅ Merged **Merged:** 9/20/2018 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (4) - [`1010a88`](https://github.com/go-gitea/gitea/commit/1010a882dbfab2abaacf035759738b4305a942d0) Fix #4877 to follow the OpenID Connect Audiences spec - [`6db8b26`](https://github.com/go-gitea/gitea/commit/6db8b267c42d00d7dc616a5c718205aba18b175f) Update goth dependency - [`b3332e2`](https://github.com/go-gitea/gitea/commit/b3332e2fe78a1d75671332e283f59390a350bf8d) Merge branch 'master' into patch-1 - [`c7872ca`](https://github.com/go-gitea/gitea/commit/c7872ca4dd1f9a2f65aa03cec73bade7c5386d53) Merge branch 'master' into patch-1 ### 📊 Changes **2 files changed** (+32 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `Gopkg.lock` (+3 -3) 📝 `vendor/github.com/markbates/goth/providers/openidConnect/openidConnect.go` (+29 -1) </details> ### 📄 Description This follows the OpenID Connect spec to support audiences with either a string or an array of strings instead of just a string. This might want to be on the release branches as well as it is a bug fix, but I personally can use master until then. I have tested this and am running it on my site now with the OpenID Connect with multiple audiences returned with no issue, the new code is not even run at all unless the old pure-string check fails. Disclaimer: I've never used and barely looked at Go thus far, and I was unable to find common functions like `filter` or so forth (or any higher order functions at all...) and based on some googling it appears that these large and unwieldy loops are the standard way to do this kind of thing in Go, but if any changes are needed please request as such with information on what I should change it to (great learning opportunity!). And of course any rights or whatever there-of related to this code I give up for whatever use this project currently wants or will want in the future. Etc... etc... Commit is signed, etc... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 13:54:18 -06:00

GiteaMirror closed this issue

2025-11-02 13:54:24 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#17532