[PR #4846] [CLOSED] Make /users/search return a UserList #17517

New Issue

GiteaMirror · 2025-11-02T13:50:01-06:00

GiteaMirror commented

2025-11-02 13:50:01 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/4846
Author: @zeripath
Created: 9/2/2018
Status: ❌ Closed

Base: master ← Head: Make-Users-Search-Return-A-UserList

📝 Commits (1)

5d92d6c Make /users/search return a UserList

📊 Changes

2 files changed (+3 additions, -9 deletions)

View changed files

📝 public/js/index.js (+1 -1)
📝 routers/api/v1/user/user.go (+2 -8)

📄 Description

As per issue #4841 . The current implementation of the /users/search API does not return a UserList but rather an object similar to the SearchResults object returned by /repos/search. This pull request fixes this code to return a UserList as per the API description and the SDK.

The issue is that this API has been wrong for at least 10 months - therefore tools may have grown up using the incorrect API. I will also create a pull requests for the opposite solution...

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/4846 **Author:** [@zeripath](https://github.com/zeripath) **Created:** 9/2/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `Make-Users-Search-Return-A-UserList` --- ### 📝 Commits (1) - [`5d92d6c`](https://github.com/go-gitea/gitea/commit/5d92d6ca9c48b9af17869c824feac880202209bf) Make /users/search return a UserList ### 📊 Changes **2 files changed** (+3 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `public/js/index.js` (+1 -1) 📝 `routers/api/v1/user/user.go` (+2 -8) </details> ### 📄 Description As per issue #4841 . The current implementation of the `/users/search` API does not return a UserList but rather an object similar to the SearchResults object returned by `/repos/search`. This pull request fixes this code to return a UserList as per the API description and the SDK. The issue is that this API has been wrong for at least 10 months - therefore tools may have grown up using the incorrect API. I will also create a pull requests for the opposite solution... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 13:50:01 -06:00

GiteaMirror closed this issue

2025-11-02 13:50:09 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#17517