github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-05-22 13:55:07 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #4729] [MERGED] User shouldn't be able to approve or reject his/her own PR #17479

New Issue
Closed
opened 2025-11-02 13:36:25 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 13:36:25 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/4729
Author: @adelowo
Created: 8/16/2018
Status: ✅ Merged
Merged: 8/20/2018
Merged by: @jonasfranz

Base: master ← Head: cannot_approve_or_reject_your_own_pr

📝 Commits (10+)

  • 8951891 Make sure author cannot reject/approve their own PR
  • 4bb258c Disable buttons in templates too
  • 27e5587 Remove unneccessary if check since the switch below catches it
  • 7e7454c Merge branch 'master' of https://github.com/go-gitea/gitea into cannot_approve_or_reject_your_own_pr
  • 55edbc3 Fix IsOwner check
  • 9f86967 Update template and remove new template variable
  • 3b019d8 Merge branch 'master' into cannot_approve_or_reject_your_own_pr
  • 2a4a5fc Add alert template and redirect to diff page on review failure
  • 654daad Redirect to files diff as a little update to #4632
  • f39a834 Merge branch 'cannot_approve_or_reject_your_own_pr' of github.com:adelowo/gitea into cannot_approve_or_reject_your_own_pr

📊 Changes

4 files changed (+28 additions, -5 deletions)

View changed files

📝 options/locale/locale_en-US.ini (+2 -0)
📝 routers/repo/pull_review.go (+22 -2)
📝 templates/repo/diff/new_review.tmpl (+3 -3)
📝 templates/repo/pulls/files.tmpl (+1 -0)

📄 Description

Fixes #4728

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/4729 **Author:** [@adelowo](https://github.com/adelowo) **Created:** 8/16/2018 **Status:** ✅ Merged **Merged:** 8/20/2018 **Merged by:** [@jonasfranz](https://github.com/jonasfranz) **Base:** `master` ← **Head:** `cannot_approve_or_reject_your_own_pr` --- ### 📝 Commits (10+) - [`8951891`](https://github.com/go-gitea/gitea/commit/8951891ded5ec565c4df86e9dd09dd6a2608d04a) Make sure author cannot reject/approve their own PR - [`4bb258c`](https://github.com/go-gitea/gitea/commit/4bb258c3b299651e11ae1ee165350ccefcc8f6a5) Disable buttons in templates too - [`27e5587`](https://github.com/go-gitea/gitea/commit/27e5587966ffc562f25bfe0e4ddab8cb70339c33) Remove unneccessary if check since the switch below catches it - [`7e7454c`](https://github.com/go-gitea/gitea/commit/7e7454c39df1141955575cae685ed0c9b774fce1) Merge branch 'master' of https://github.com/go-gitea/gitea into cannot_approve_or_reject_your_own_pr - [`55edbc3`](https://github.com/go-gitea/gitea/commit/55edbc33e317f727be0ed0d5e6ae3217459185e1) Fix IsOwner check - [`9f86967`](https://github.com/go-gitea/gitea/commit/9f86967d921f62f89192962c442af4a44a5e5850) Update template and remove new template variable - [`3b019d8`](https://github.com/go-gitea/gitea/commit/3b019d86989d35b8cba44af14e52de2dae0dc7eb) Merge branch 'master' into cannot_approve_or_reject_your_own_pr - [`2a4a5fc`](https://github.com/go-gitea/gitea/commit/2a4a5fcda95c02185138f50b1c21f69ef9d553dc) Add alert template and redirect to diff page on review failure - [`654daad`](https://github.com/go-gitea/gitea/commit/654daad82fd94ffd88c32b80252bbbac559a5537) Redirect to files diff as a little update to #4632 - [`f39a834`](https://github.com/go-gitea/gitea/commit/f39a834df606a3a754292f95b19dd3a2ed09f803) Merge branch 'cannot_approve_or_reject_your_own_pr' of github.com:adelowo/gitea into cannot_approve_or_reject_your_own_pr ### 📊 Changes **4 files changed** (+28 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `options/locale/locale_en-US.ini` (+2 -0) 📝 `routers/repo/pull_review.go` (+22 -2) 📝 `templates/repo/diff/new_review.tmpl` (+3 -3) 📝 `templates/repo/pulls/files.tmpl` (+1 -0) </details> ### 📄 Description Fixes #4728 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 13:36:25 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#17479
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?