github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-15 20:09:18 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #4710] [MERGED] Improve URL validation for external wiki and external issues #17469

New Issue
Closed
opened 2025-11-02 13:34:14 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 13:34:14 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/4710
Author: @lafriks
Created: 8/14/2018
Status: ✅ Merged
Merged: 8/15/2018
Merged by: @lafriks

Base: master ← Head: fix/url_validation_ext_issue

📝 Commits (3)

  • 71ad290 Improve URL validation for external wiki and external issues
  • 6423108 Merge branch 'master' into fix/url_validation_ext_issue
  • 960c1d8 Do not allow also localhost address for external URLs

📊 Changes

5 files changed (+180 additions, -10 deletions)

View changed files

📝 modules/validation/binding.go (+3 -8)
➕ modules/validation/helpers.go (+77 -0)
➕ modules/validation/helpers_test.go (+90 -0)
📝 options/locale/locale_en-US.ini (+1 -0)
📝 routers/repo/setting.go (+9 -2)

📄 Description

Fixes #4703

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/4710 **Author:** [@lafriks](https://github.com/lafriks) **Created:** 8/14/2018 **Status:** ✅ Merged **Merged:** 8/15/2018 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `master` ← **Head:** `fix/url_validation_ext_issue` --- ### 📝 Commits (3) - [`71ad290`](https://github.com/go-gitea/gitea/commit/71ad290b68779dbbed92aada292487a667dba952) Improve URL validation for external wiki and external issues - [`6423108`](https://github.com/go-gitea/gitea/commit/6423108d8ffe747924d203be8907e1a178d6f12f) Merge branch 'master' into fix/url_validation_ext_issue - [`960c1d8`](https://github.com/go-gitea/gitea/commit/960c1d8e8f1fced0e75caf0cf48ad637bd8cb6c9) Do not allow also localhost address for external URLs ### 📊 Changes **5 files changed** (+180 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `modules/validation/binding.go` (+3 -8) ➕ `modules/validation/helpers.go` (+77 -0) ➕ `modules/validation/helpers_test.go` (+90 -0) 📝 `options/locale/locale_en-US.ini` (+1 -0) 📝 `routers/repo/setting.go` (+9 -2) </details> ### 📄 Description Fixes #4703 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 13:34:14 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#17469
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?