github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #4682] [MERGED] Code review UI improvements and bugfixes #17461

New Issue
Closed
opened 2025-11-02 13:32:24 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 13:32:24 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/4682
Author: @lafriks
Created: 8/12/2018
Status: ✅ Merged
Merged: 9/17/2018
Merged by: @lafriks

Base: master ← Head: feat/improve_code_review_ui

📝 Commits (8)

  • 2a93e84 Code review UI improvements
  • cf75069 More fixes to dark theme
  • b36f5f3 Style fix
  • 382a558 Fix to allow add code review comments only on review files tab
  • cd1a2b2 More readability dark style fixes
  • 5307c2e Fix commenting on deleted files. Fixes #4752
  • 470053c Fix line blame getting for multiple corner cases
  • 9ea29ed Merge branch 'master' into feat/improve_code_review_ui

📊 Changes

11 files changed (+101 additions, -33 deletions)

View changed files

📝 models/git_diff.go (+6 -2)
📝 models/issue_comment.go (+10 -10)
📝 public/css/index.css (+1 -1)
📝 public/css/theme-arc-green.css (+1 -1)
📝 public/js/index.js (+2 -2)
📝 public/less/_review.less (+21 -10)
📝 public/less/themes/arc-green.less (+43 -2)
📝 routers/repo/pull_review.go (+12 -2)
📝 templates/repo/diff/box.tmpl (+1 -1)
📝 templates/repo/diff/comment_form.tmpl (+3 -1)
📝 templates/repo/diff/section_unified.tmpl (+1 -1)

📄 Description

  1. Allow review comment/reject without message if code comments have been already added
  2. Dark theme fixes for code comments
  3. Make visually better padding for code comment replies
  4. Do not show button Add single comment if there is already started review
  5. Fixes Feature: Select a template by default on the Repository create page (#4901)
  6. Fixes Display binary file size change on commit page. (#4752)
  7. Fixes Long commit messages are not truncated in overview (#4909)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/4682 **Author:** [@lafriks](https://github.com/lafriks) **Created:** 8/12/2018 **Status:** ✅ Merged **Merged:** 9/17/2018 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `master` ← **Head:** `feat/improve_code_review_ui` --- ### 📝 Commits (8) - [`2a93e84`](https://github.com/go-gitea/gitea/commit/2a93e8482e3d77a1022966ed7ef4adcf140f7a77) Code review UI improvements - [`cf75069`](https://github.com/go-gitea/gitea/commit/cf75069feeb2a8e3393ab07fce3f86a137c9fd0d) More fixes to dark theme - [`b36f5f3`](https://github.com/go-gitea/gitea/commit/b36f5f336511e6cac1a46f2534141b9c8e37af89) Style fix - [`382a558`](https://github.com/go-gitea/gitea/commit/382a5582af70c35f04bb93108becd9deed254fb3) Fix to allow add code review comments only on review files tab - [`cd1a2b2`](https://github.com/go-gitea/gitea/commit/cd1a2b226f061a2538af5324daa91865f9fa41a9) More readability dark style fixes - [`5307c2e`](https://github.com/go-gitea/gitea/commit/5307c2ed60efbf16a29288f24357e16970fe1d54) Fix commenting on deleted files. Fixes #4752 - [`470053c`](https://github.com/go-gitea/gitea/commit/470053c1c1002dc335259d3b2c31eafa4efab2a4) Fix line blame getting for multiple corner cases - [`9ea29ed`](https://github.com/go-gitea/gitea/commit/9ea29edc19e413a953824eb2e8f56297d88a2a79) Merge branch 'master' into feat/improve_code_review_ui ### 📊 Changes **11 files changed** (+101 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `models/git_diff.go` (+6 -2) 📝 `models/issue_comment.go` (+10 -10) 📝 `public/css/index.css` (+1 -1) 📝 `public/css/theme-arc-green.css` (+1 -1) 📝 `public/js/index.js` (+2 -2) 📝 `public/less/_review.less` (+21 -10) 📝 `public/less/themes/arc-green.less` (+43 -2) 📝 `routers/repo/pull_review.go` (+12 -2) 📝 `templates/repo/diff/box.tmpl` (+1 -1) 📝 `templates/repo/diff/comment_form.tmpl` (+3 -1) 📝 `templates/repo/diff/section_unified.tmpl` (+1 -1) </details> ### 📄 Description 1. Allow review comment/reject without message if code comments have been already added 2. Dark theme fixes for code comments 3. Make visually better padding for code comment replies 4. Do not show button `Add single comment` if there is already started review 5. Fixes #4901 6. Fixes #4752 7. Fixes #4909 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 13:32:24 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#17461
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?