github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-13 11:31:28 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #4632] [MERGED] prevent empty review comment #17438

New Issue
Closed
opened 2025-11-02 13:22:49 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 13:22:49 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/4632
Author: @adelowo
Created: 8/7/2018
Status: ✅ Merged
Merged: 8/7/2018
Merged by: @lafriks

Base: master ← Head: reject_empty_review_comment

📝 Commits (3)

📊 Changes

4 files changed (+57 additions, -0 deletions)

View changed files

📝 modules/auth/repo_form.go (+8 -0)
➕ modules/auth/repo_form_test.go (+41 -0)
📝 options/locale/locale_en-US.ini (+1 -0)
📝 routers/repo/pull_review.go (+7 -0)

📄 Description

Fixes #4630

screen shot 2018-08-07 at 13 01 32

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/4632 **Author:** [@adelowo](https://github.com/adelowo) **Created:** 8/7/2018 **Status:** ✅ Merged **Merged:** 8/7/2018 **Merged by:** [@lafriks](https://github.com/lafriks) **Base:** `master` ← **Head:** `reject_empty_review_comment` --- ### 📝 Commits (3) - [`3757e6a`](https://github.com/go-gitea/gitea/commit/3757e6a3b53728330e4d267bffba27ff229f91a2) prevent empty review comment - [`ce6718e`](https://github.com/go-gitea/gitea/commit/ce6718e5ddbc696532a20e62daab75309f564675) add tests - [`12124ef`](https://github.com/go-gitea/gitea/commit/12124ef9337e4d35bfeeccdb1286f0f80db064b5) add comment ### 📊 Changes **4 files changed** (+57 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `modules/auth/repo_form.go` (+8 -0) ➕ `modules/auth/repo_form_test.go` (+41 -0) 📝 `options/locale/locale_en-US.ini` (+1 -0) 📝 `routers/repo/pull_review.go` (+7 -0) </details> ### 📄 Description Fixes #4630 <img width="1920" alt="screen shot 2018-08-07 at 13 01 32" src="https://user-images.githubusercontent.com/12677701/43774973-e8e95f84-9a42-11e8-8b96-0995f354ff56.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 13:22:55 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#17438
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?