github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-05-10 15:39:40 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[PR #4583] [MERGED] Fix failure on creating pull request with assignees (#4419) #17425

New Issue
Closed
opened 2025-11-02 13:19:33 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 13:19:33 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/4583
Author: @SagePtr
Created: 8/1/2018
Status: ✅ Merged
Merged: 8/16/2018
Merged by: @lunny

Base: master ← Head: issue4419

📝 Commits (3)

  • cf5e259 Fix failure on creating pull request with assignees (#4419)
  • 6a09222 Merge branch 'master' into issue4419
  • b40c9e2 Merge branch 'master' into issue4419

📊 Changes

2 files changed (+7 additions, -3 deletions)

View changed files

📝 models/issue.go (+1 -1)
📝 models/issue_assignees.go (+6 -2)

📄 Description

Fixes #4419

If pull request is in the middle of creation, it's impossible to call 'pull_request' webhook with action 'assign' in changeAssignee function. Now it's just skipped.

I don't know if this extra webhooks should be called after pull request is created, because 'pull_request' webhook with action 'opened' is called anyway and it already contains assignees section. For now additional assign webhooks are just skipped.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/4583 **Author:** [@SagePtr](https://github.com/SagePtr) **Created:** 8/1/2018 **Status:** ✅ Merged **Merged:** 8/16/2018 **Merged by:** [@lunny](https://github.com/lunny) **Base:** `master` ← **Head:** `issue4419` --- ### 📝 Commits (3) - [`cf5e259`](https://github.com/go-gitea/gitea/commit/cf5e25968ff8541dadc5a07aefe4bb835513cab6) Fix failure on creating pull request with assignees (#4419) - [`6a09222`](https://github.com/go-gitea/gitea/commit/6a092225122fbe5572646ad9d8d2f1b53a2a1f1a) Merge branch 'master' into issue4419 - [`b40c9e2`](https://github.com/go-gitea/gitea/commit/b40c9e29e6eec2bebb4daebed41f8fcb108c2d61) Merge branch 'master' into issue4419 ### 📊 Changes **2 files changed** (+7 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `models/issue.go` (+1 -1) 📝 `models/issue_assignees.go` (+6 -2) </details> ### 📄 Description Fixes #4419 If pull request is in the middle of creation, it's impossible to call 'pull_request' webhook with action 'assign' in changeAssignee function. Now it's just skipped. I don't know if this extra webhooks should be called after pull request is created, because 'pull_request' webhook with action 'opened' is called anyway and it already contains assignees section. For now additional assign webhooks are just skipped. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-02 13:19:33 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#17425
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?