[PR #4582] [CLOSED] Fix failure on creating pull request with assignees (#4419) #17424

New Issue

GiteaMirror · 2025-11-02T13:19:20-06:00

GiteaMirror commented

2025-11-02 13:19:20 -06:00

📋 Pull Request Information

Original PR: https://github.com/go-gitea/gitea/pull/4582
Author: @SagePtr
Created: 8/1/2018
Status: ❌ Closed

Base: master ← Head: issue4419

📝 Commits (1)

456a8ed Fix failure on creating pull request with assignees (#4419)

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 models/issue_assignees.go (+4 -0)

📄 Description

Fixes #4419

If pull request is in the middle of creation, it's impossible to call 'pull_request' webhook with action 'assign' in changeAssignee function. Now it's just skipped.

I don't know if this extra webhooks should be called after pull request is created, because 'pull_request' webhook with action 'opened' is called anyway and it already contains assignees section. For now additional assign webhooks are just skipped.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-gitea/gitea/pull/4582 **Author:** [@SagePtr](https://github.com/SagePtr) **Created:** 8/1/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `issue4419` --- ### 📝 Commits (1) - [`456a8ed`](https://github.com/go-gitea/gitea/commit/456a8eddbf4237f2a85e2ed5cf5e4d6b9f2efb71) Fix failure on creating pull request with assignees (#4419) ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `models/issue_assignees.go` (+4 -0) </details> ### 📄 Description Fixes #4419 If pull request is in the middle of creation, it's impossible to call '```pull_request```' webhook with action '```assign```' in changeAssignee function. Now it's just skipped. I don't know if this extra webhooks should be called after pull request is created, because '```pull_request```' webhook with action '```opened```' is called anyway and it already contains ```assignees``` section. For now additional ```assign``` webhooks are just skipped. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 13:19:20 -06:00

GiteaMirror closed this issue

2025-11-02 13:19:24 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#17424